test/cctest/interpreter/bytecode_expectations/ForIn.golden - Issue 2038323002: [interpreter] Filter expression positions at source.

Unified Diff: test/cctest/interpreter/bytecode_expectations/ForIn.golden

Issue 2038323002: [interpreter] Filter expression positions at source. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth-0060-source-position-testing

Patch Set: Fix expression positions on StackCheck that this CL broke. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/interpreter/bytecode-array-builder.h ('K') | « test/cctest/interpreter/bytecode_expectations/DoExpression.golden ('k') | test/cctest/interpreter/bytecode_expectations/ForOf.golden » ('j') | test/cctest/interpreter/test-source-positions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/interpreter/bytecode_expectations/ForIn.golden

diff --git a/test/cctest/interpreter/bytecode_expectations/ForIn.golden b/test/cctest/interpreter/bytecode_expectations/ForIn.golden

index e216bd6c5350c528c376815488ba400e0a32131f..8bc9d2a33620858d809b8edd0ca30e946d6d6ec3 100644

--- a/test/cctest/interpreter/bytecode_expectations/ForIn.golden

+++ b/test/cctest/interpreter/bytecode_expectations/ForIn.golden

@@ -105,34 +105,33 @@ snippet: "

frame size: 9

parameter count: 1

-bytecode array length: 55

+bytecode array length: 54

bytecodes: [

/* 30 E> */ B(StackCheck),

/* 42 S> */ B(LdaZero),

B(Star), R(1),

/* 59 S> */ B(CreateArrayLiteral), U8(0), U8(0), U8(3),

- B(JumpIfUndefined), U8(45),

- B(JumpIfNull), U8(43),

+ B(JumpIfUndefined), U8(44),

+ B(JumpIfNull), U8(42),

B(ToObject),

B(ForInPrepare), R(4),

B(Star), R(3),

B(LdaZero),

B(Star), R(7),

/* 54 S> */ B(ForInDone), R(7), R(6),

- B(JumpIfTrue), U8(30),

+ B(JumpIfTrue), U8(29),

B(ForInNext), R(3), R(7), R(4), U8(1),

- B(JumpIfUndefined), U8(17),

+ B(JumpIfUndefined), U8(16),

B(Star), R(0),

/* 45 E> */ B(StackCheck),

B(Star), R(2),

- /* 70 S> */ B(Nop),

- /* 75 E> */ B(Ldar), R(0),

- B(Add), R(1),

+ /* 70 S> */ B(Ldar), R(0),

+ /* 75 E> */ B(Add), R(1),

B(Mov), R(1), R(8),

- /* 72 E> */ B(Star), R(1),

- B(ForInStep), R(7),

+ B(Star), R(1),

+ /* 72 E> */ B(ForInStep), R(7),

B(Star), R(7),

- B(Jump), U8(-31),

+ B(Jump), U8(-30),

B(LdaUndefined),

/* 80 S> */ B(Return),

]

@@ -152,27 +151,26 @@ snippet: "

frame size: 8

parameter count: 1

-bytecode array length: 82

+bytecode array length: 80

bytecodes: [

/* 30 E> */ B(StackCheck),

/* 42 S> */ B(CreateObjectLiteral), U8(0), U8(0), U8(1),

B(Star), R(1),

B(Star), R(0),

/* 77 S> */ B(CreateArrayLiteral), U8(1), U8(1), U8(3),

- B(JumpIfUndefined), U8(67),

- B(JumpIfNull), U8(65),

+ B(JumpIfUndefined), U8(65),

+ B(JumpIfNull), U8(63),

B(ToObject),

B(ForInPrepare), R(2),

B(Star), R(1),

B(LdaZero),

B(Star), R(5),

/* 68 S> */ B(ForInDone), R(5), R(4),

- B(JumpIfTrue), U8(52),

+ B(JumpIfTrue), U8(50),

B(ForInNext), R(1), R(5), R(2), U8(9),

- B(JumpIfUndefined), U8(39),

+ B(JumpIfUndefined), U8(37),

B(Star), R(6),

- /* 67 E> */ B(Ldar), R(6),

- B(StaNamedPropertySloppy), R(0), U8(2), U8(7),

+ /* 67 E> */ B(StaNamedPropertySloppy), R(0), U8(2), U8(7),

/* 62 E> */ B(StackCheck),

/* 95 S> */ B(Nop),

/* 100 E> */ B(LdrNamedProperty), R(0), U8(2), U8(3), R(7),

@@ -188,7 +186,7 @@ bytecodes: [

/* 143 S> */ B(Jump), U8(8),

B(ForInStep), R(5),

B(Star), R(5),

- B(Jump), U8(-53),

+ B(Jump), U8(-51),

B(LdaUndefined),

/* 152 S> */ B(Return),

]

@@ -207,36 +205,35 @@ snippet: "

frame size: 9

parameter count: 1

-bytecode array length: 62

+bytecode array length: 61

bytecodes: [

/* 30 E> */ B(StackCheck),

/* 42 S> */ B(CreateArrayLiteral), U8(0), U8(0), U8(3),

B(Star), R(0),

/* 72 S> */ B(CreateArrayLiteral), U8(1), U8(1), U8(3),

- B(JumpIfUndefined), U8(49),

- B(JumpIfNull), U8(47),

+ B(JumpIfUndefined), U8(48),

+ B(JumpIfNull), U8(46),

B(ToObject),

B(ForInPrepare), R(2),

B(Star), R(1),

B(LdaZero),

B(Star), R(5),

/* 65 S> */ B(ForInDone), R(5), R(4),

- B(JumpIfTrue), U8(34),

+ B(JumpIfTrue), U8(33),

B(ForInNext), R(1), R(5), R(2), U8(7),

- B(JumpIfUndefined), U8(21),

+ B(JumpIfUndefined), U8(20),

B(Star), R(6),

- /* 64 E> */ B(LdaZero),

+ B(LdaZero),

B(Star), R(8),

B(Ldar), R(6),

- B(StaKeyedPropertySloppy), R(0), R(8), U8(5),

+ /* 64 E> */ B(StaKeyedPropertySloppy), R(0), R(8), U8(5),

/* 59 E> */ B(StackCheck),

- /* 83 S> */ B(Nop),

- /* 91 E> */ B(LdaSmi), U8(3),

- B(LdaKeyedProperty), R(0), U8(3),

+ /* 83 S> */ B(LdaSmi), U8(3),

+ /* 91 E> */ B(LdaKeyedProperty), R(0), U8(3),

/* 98 S> */ B(Return),

B(ForInStep), R(5),

B(Star), R(5),

- B(Jump), U8(-35),

+ B(Jump), U8(-34),

B(LdaUndefined),

/* 98 S> */ B(Return),

]