Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden

Issue 2038323002: [interpreter] Filter expression positions at source. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth-0060-source-position-testing
Patch Set: Fix expression positions on StackCheck that this CL broke. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/interpreter/bytecode-array-builder.h ('K') | « test/cctest/interpreter/bytecode_expectations/CallNew.golden ('k') | test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden » ('j') | test/cctest/interpreter/test-source-positions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden b/test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden
index 8efc41bbf45accb30ca892e218cb006333e7b114..dc1e110a713746a496c6cfb8816cb1421f72f463 100644
--- a/test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden
+++ b/test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden
@@ -24,20 +24,19 @@ snippet: "
"
frame size: 7
parameter count: 1
-bytecode array length: 55
+bytecode array length: 54
bytecodes: [
B(Mov), R(closure), R(0),
/* 99 E> */ B(StackCheck),
- /* 104 S> */ B(Nop),
- /* 111 E> */ B(Mov), R(this), R(3),
+ /* 104 S> */ B(Mov), R(this), R(3),
B(Ldar), R(closure),
B(JumpIfNotHole), U8(11),
B(LdaConstant), U8(0),
B(Star), R(6),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(6), U8(1),
+ /* 111 E> */ B(CallRuntime), U16(Runtime::kThrowReferenceError), R(6), U8(1),
B(Star), R(6),
- /* 111 E> */ B(LdaConstant), U8(1),
- B(LdrKeyedProperty), R(6), U8(3), R(4),
+ B(LdaConstant), U8(1),
+ /* 111 E> */ B(LdrKeyedProperty), R(6), U8(3), R(4),
B(LdaConstant), U8(2),
B(Star), R(5),
B(CallRuntime), U16(Runtime::kLoadFromSuper), R(3), U8(3),
@@ -74,35 +73,33 @@ snippet: "
"
frame size: 6
parameter count: 1
-bytecode array length: 77
+bytecode array length: 75
bytecodes: [
B(Mov), R(closure), R(0),
/* 125 E> */ B(StackCheck),
- /* 130 S> */ B(Nop),
- /* 130 E> */ B(Mov), R(this), R(1),
+ /* 130 S> */ B(Mov), R(this), R(1),
B(Ldar), R(closure),
B(JumpIfNotHole), U8(11),
B(LdaConstant), U8(0),
B(Star), R(5),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(5), U8(1),
+ /* 130 E> */ B(CallRuntime), U16(Runtime::kThrowReferenceError), R(5), U8(1),
B(Star), R(5),
- /* 130 E> */ B(LdaConstant), U8(1),
- B(LdrKeyedProperty), R(5), U8(1), R(2),
+ B(LdaConstant), U8(1),
+ /* 130 E> */ B(LdrKeyedProperty), R(5), U8(1), R(2),
B(LdaConstant), U8(2),
B(Star), R(3),
B(LdaSmi), U8(2),
- /* 138 E> */ B(Star), R(4),
- B(CallRuntime), U16(Runtime::kStoreToSuper_Strict), R(1), U8(4),
- /* 143 S> */ B(Nop),
- /* 150 E> */ B(Mov), R(this), R(1),
+ B(Star), R(4),
+ /* 138 E> */ B(CallRuntime), U16(Runtime::kStoreToSuper_Strict), R(1), U8(4),
+ /* 143 S> */ B(Mov), R(this), R(1),
B(Ldar), R(0),
B(JumpIfNotHole), U8(11),
B(LdaConstant), U8(0),
B(Star), R(4),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1),
+ /* 150 E> */ B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1),
B(Star), R(4),
- /* 150 E> */ B(LdaConstant), U8(1),
- B(LdrKeyedProperty), R(4), U8(3), R(2),
+ B(LdaConstant), U8(1),
+ /* 150 E> */ B(LdrKeyedProperty), R(4), U8(3), R(2),
B(LdaConstant), U8(2),
B(Star), R(3),
B(CallRuntime), U16(Runtime::kLoadFromSuper), R(1), U8(3),
@@ -146,19 +143,19 @@ bytecodes: [
B(Star), R(2),
B(LdaSmi), U8(1),
B(Star), R(3),
- /* 118 E> */ B(Ldar), R(0),
+ B(Ldar), R(0),
B(JumpIfNotHole), U8(11),
B(LdaConstant), U8(1),
B(Star), R(4),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1),
+ /* 118 E> */ B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1),
/* 118 E> */ B(New), R(2), R(3), U8(1),
- /* 118 E> */ B(Star), R(2),
+ B(Star), R(2),
B(Ldar), R(this),
B(JumpIfNotHole), U8(4),
B(Jump), U8(11),
B(LdaConstant), U8(2),
B(Star), R(3),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(3), U8(1),
+ /* 118 E> */ B(CallRuntime), U16(Runtime::kThrowReferenceError), R(3), U8(1),
B(Mov), R(2), R(this),
/* 128 S> */ B(Ldar), R(this),
B(JumpIfNotHole), U8(11),
@@ -212,19 +209,19 @@ bytecodes: [
B(Star), R(2),
B(CallRuntime), U16(Runtime::k_GetSuperConstructor), R(2), U8(1),
B(Star), R(2),
- /* 117 E> */ B(Ldar), R(0),
+ B(Ldar), R(0),
B(JumpIfNotHole), U8(11),
B(LdaConstant), U8(1),
B(Star), R(3),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(3), U8(1),
+ /* 117 E> */ B(CallRuntime), U16(Runtime::kThrowReferenceError), R(3), U8(1),
/* 117 E> */ B(New), R(2), R(0), U8(0),
- /* 117 E> */ B(Star), R(2),
+ B(Star), R(2),
B(Ldar), R(this),
B(JumpIfNotHole), U8(4),
B(Jump), U8(11),
B(LdaConstant), U8(2),
B(Star), R(3),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(3), U8(1),
+ /* 117 E> */ B(CallRuntime), U16(Runtime::kThrowReferenceError), R(3), U8(1),
B(Mov), R(2), R(this),
/* 126 S> */ B(Ldar), R(this),
B(JumpIfNotHole), U8(11),
« src/interpreter/bytecode-array-builder.h ('K') | « test/cctest/interpreter/bytecode_expectations/CallNew.golden ('k') | test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden » ('j') | test/cctest/interpreter/test-source-positions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698