Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/bytecode_expectations/BasicLoops.golden

Issue 2038323002: [interpreter] Filter expression positions at source. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth-0060-source-position-testing
Patch Set: Fix expression positions on StackCheck that this CL broke. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/interpreter/bytecode-array-builder.h ('K') | « test/cctest/interpreter/bytecode_expectations/BasicBlockToBoolean.golden ('k') | test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden » ('j') | test/cctest/interpreter/test-source-positions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/BasicLoops.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden b/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden
index ee125c87b42675b4cbe77944d75cc92dd8157af9..8be4e9d698f7c7355e1143802f5617c05d5acee6 100644
--- a/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden
+++ b/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden
@@ -71,7 +71,7 @@ bytecodes: [
/* 42 S> */ B(LdaZero),
B(Star), R(0),
/* 53 S> */ B(LdaSmi), U8(1),
- /* 53 E> */ B(Star), R(1),
+ B(Star), R(1),
/* 65 S> */ B(LdaSmi), U8(10),
/* 65 E> */ B(TestLessThan), R(0),
B(JumpIfFalse), U8(33),
@@ -118,7 +118,7 @@ bytecode array length: 55
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
- /* 42 E> */ B(Star), R(0),
+ B(Star), R(0),
/* 45 E> */ B(StackCheck),
/* 62 S> */ B(LdaZero),
/* 68 E> */ B(TestLessThan), R(0),
@@ -142,7 +142,7 @@ bytecodes: [
/* 164 S> */ B(Jump), U8(10),
/* 173 S> */ B(LdaSmi), U8(1),
B(Add), R(0),
- /* 175 E> */ B(Star), R(0),
+ B(Star), R(0),
B(Jump), U8(-46),
/* 186 S> */ B(Ldar), R(0),
/* 196 S> */ B(Return),
@@ -171,7 +171,7 @@ bytecode array length: 41
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
- /* 42 E> */ B(Star), R(0),
+ B(Star), R(0),
/* 45 E> */ B(StackCheck),
/* 71 S> */ B(LdaSmi), U8(3),
/* 71 E> */ B(TestLessThan), R(0),
@@ -183,7 +183,7 @@ bytecodes: [
/* 94 S> */ B(Jump), U8(10),
/* 105 S> */ B(LdaSmi), U8(1),
B(Add), R(0),
- /* 107 E> */ B(Star), R(0),
+ B(Star), R(0),
B(Jump), U8(-21),
/* 122 S> */ B(LdaSmi), U8(1),
B(Add), R(0),
@@ -216,7 +216,7 @@ bytecodes: [
/* 42 S> */ B(LdaSmi), U8(10),
B(Star), R(0),
/* 54 S> */ B(LdaSmi), U8(1),
- /* 54 E> */ B(Star), R(1),
+ B(Star), R(1),
/* 64 S> */ B(Ldar), R(0),
B(JumpIfToBooleanFalse), U8(17),
/* 57 E> */ B(StackCheck),
@@ -225,7 +225,7 @@ bytecodes: [
B(Star), R(1),
/* 85 S> */ B(LdaSmi), U8(1),
B(Sub), R(0),
- /* 87 E> */ B(Star), R(0),
+ B(Star), R(0),
B(Jump), U8(-17),
/* 98 S> */ B(Ldar), R(1),
/* 108 S> */ B(Return),
@@ -254,7 +254,7 @@ bytecodes: [
/* 42 S> */ B(LdaZero),
B(Star), R(0),
/* 53 S> */ B(LdaSmi), U8(1),
- /* 53 E> */ B(Star), R(1),
+ B(Star), R(1),
/* 56 E> */ B(StackCheck),
/* 63 S> */ B(LdaSmi), U8(10),
B(Mul), R(1),
@@ -269,7 +269,7 @@ bytecodes: [
/* 110 S> */ B(Jump), U8(8),
/* 122 S> */ B(LdaSmi), U8(1),
B(Add), R(0),
- /* 124 E> */ B(Star), R(0),
+ B(Star), R(0),
/* 144 S> */ B(LdaSmi), U8(10),
/* 144 E> */ B(TestLessThan), R(0),
B(JumpIfTrue), U8(-33),
@@ -299,14 +299,14 @@ bytecodes: [
/* 42 S> */ B(LdaSmi), U8(10),
B(Star), R(0),
/* 54 S> */ B(LdaSmi), U8(1),
- /* 54 E> */ B(Star), R(1),
+ B(Star), R(1),
/* 57 E> */ B(StackCheck),
/* 64 S> */ B(LdaSmi), U8(12),
B(Mul), R(1),
B(Star), R(1),
/* 78 S> */ B(LdaSmi), U8(1),
B(Sub), R(0),
- /* 80 E> */ B(Star), R(0),
+ B(Star), R(0),
/* 98 S> */ B(Ldar), R(0),
B(JumpIfToBooleanTrue), U8(-15),
/* 102 S> */ B(Ldar), R(1),
@@ -336,7 +336,7 @@ bytecodes: [
/* 42 S> */ B(LdaZero),
B(Star), R(0),
/* 53 S> */ B(LdaSmi), U8(1),
- /* 53 E> */ B(Star), R(1),
+ B(Star), R(1),
/* 56 E> */ B(StackCheck),
/* 63 S> */ B(LdaSmi), U8(10),
B(Mul), R(1),
@@ -379,7 +379,7 @@ bytecodes: [
/* 42 S> */ B(LdaZero),
B(Star), R(0),
/* 53 S> */ B(LdaSmi), U8(1),
- /* 53 E> */ B(Star), R(1),
+ B(Star), R(1),
/* 56 E> */ B(StackCheck),
/* 63 S> */ B(LdaSmi), U8(10),
B(Mul), R(1),
@@ -419,7 +419,7 @@ bytecode array length: 31
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
- /* 42 E> */ B(Star), R(0),
+ B(Star), R(0),
/* 45 E> */ B(StackCheck),
/* 58 S> */ B(LdaSmi), U8(1),
/* 64 E> */ B(TestEqual), R(0),
@@ -431,7 +431,7 @@ bytecodes: [
/* 91 S> */ B(Jump), U8(8),
/* 103 S> */ B(LdaSmi), U8(1),
B(Add), R(0),
- /* 105 E> */ B(Star), R(0),
+ B(Star), R(0),
B(Jump), U8(-23),
B(LdaUndefined),
/* 116 S> */ B(Return),
@@ -455,7 +455,7 @@ bytecode array length: 31
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 47 S> */ B(LdaZero),
- /* 47 E> */ B(Star), R(0),
+ B(Star), R(0),
/* 34 E> */ B(StackCheck),
/* 56 S> */ B(LdaSmi), U8(1),
/* 62 E> */ B(TestEqual), R(0),
@@ -467,7 +467,7 @@ bytecodes: [
/* 89 S> */ B(Jump), U8(8),
/* 101 S> */ B(LdaSmi), U8(1),
B(Add), R(0),
- /* 103 E> */ B(Star), R(0),
+ B(Star), R(0),
B(Jump), U8(-23),
B(LdaUndefined),
/* 114 S> */ B(Return),
@@ -491,7 +491,7 @@ bytecode array length: 31
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
- /* 42 E> */ B(Star), R(0),
+ B(Star), R(0),
/* 45 E> */ B(StackCheck),
/* 68 S> */ B(LdaSmi), U8(1),
/* 74 E> */ B(TestEqual), R(0),
@@ -503,7 +503,7 @@ bytecodes: [
/* 101 S> */ B(Jump), U8(2),
/* 55 S> */ B(LdaSmi), U8(1),
B(Add), R(0),
- /* 55 E> */ B(Star), R(0),
+ B(Star), R(0),
B(Jump), U8(-23),
B(LdaUndefined),
/* 113 S> */ B(Return),
@@ -526,7 +526,7 @@ bytecode array length: 31
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 47 S> */ B(LdaZero),
- /* 47 E> */ B(Star), R(0),
+ B(Star), R(0),
/* 34 E> */ B(StackCheck),
/* 66 S> */ B(LdaSmi), U8(1),
/* 72 E> */ B(TestEqual), R(0),
@@ -538,7 +538,7 @@ bytecodes: [
/* 99 S> */ B(Jump), U8(2),
/* 53 S> */ B(LdaSmi), U8(1),
B(Add), R(0),
- /* 53 E> */ B(Star), R(0),
+ B(Star), R(0),
B(Jump), U8(-23),
B(LdaUndefined),
/* 111 S> */ B(Return),
@@ -564,7 +564,7 @@ bytecodes: [
/* 42 S> */ B(LdaZero),
B(Star), R(0),
/* 58 S> */ B(LdaZero),
- /* 58 E> */ B(Star), R(1),
+ B(Star), R(1),
/* 63 S> */ B(LdaSmi), U8(100),
/* 63 E> */ B(TestLessThan), R(1),
B(JumpIfFalse), U8(19),
@@ -575,7 +575,7 @@ bytecodes: [
/* 98 S> */ B(Jump), U8(2),
/* 72 S> */ B(LdaSmi), U8(1),
B(Add), R(1),
- /* 72 E> */ B(Star), R(1),
+ B(Star), R(1),
B(Jump), U8(-21),
B(LdaUndefined),
/* 110 S> */ B(Return),
@@ -601,16 +601,16 @@ bytecodes: [
/* 42 S> */ B(LdaSmi), U8(1),
B(Star), R(0),
/* 58 S> */ B(LdaSmi), U8(10),
- /* 58 E> */ B(Star), R(1),
+ B(Star), R(1),
/* 62 S> */ B(Ldar), R(1),
B(JumpIfToBooleanFalse), U8(16),
/* 45 E> */ B(StackCheck),
/* 74 S> */ B(LdaSmi), U8(12),
B(Mul), R(0),
- /* 76 E> */ B(Star), R(0),
+ B(Star), R(0),
/* 67 S> */ B(Ldar), R(1),
B(Dec),
- /* 67 E> */ B(Star), R(1),
+ B(Star), R(1),
B(Jump), U8(-16),
/* 88 S> */ B(Ldar), R(0),
/* 98 S> */ B(Return),
@@ -662,7 +662,7 @@ bytecodes: [
/* 42 S> */ B(LdaZero),
B(Star), R(0),
/* 58 S> */ B(LdaZero),
- /* 58 E> */ B(Star), R(1),
+ B(Star), R(1),
/* 45 E> */ B(StackCheck),
/* 76 S> */ B(LdaSmi), U8(1),
B(Add), R(0),
@@ -673,7 +673,7 @@ bytecodes: [
/* 102 S> */ B(Jump), U8(9),
/* 69 S> */ B(Ldar), R(1),
B(Inc),
- /* 69 E> */ B(Star), R(1),
+ B(Star), R(1),
B(Jump), U8(-20),
/* 112 S> */ B(Ldar), R(0),
/* 122 S> */ B(Return),
@@ -701,7 +701,7 @@ bytecode array length: 119
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
- /* 42 E> */ B(Star), R(1),
+ B(Star), R(1),
/* 52 S> */ B(Ldar), R(1),
B(JumpIfToBooleanFalse), U8(111),
/* 45 E> */ B(StackCheck),
@@ -739,8 +739,8 @@ bytecodes: [
B(ToNumber),
B(Star), R(4),
B(Inc),
- /* 127 E> */ B(Star), R(5),
- B(LdaContextSlot), R(context), U8(4),
+ B(Star), R(5),
+ /* 127 E> */ B(LdaContextSlot), R(context), U8(4),
B(JumpIfNotHole), U8(11),
B(LdaConstant), U8(3),
B(Star), R(6),
« src/interpreter/bytecode-array-builder.h ('K') | « test/cctest/interpreter/bytecode_expectations/BasicBlockToBoolean.golden ('k') | test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden » ('j') | test/cctest/interpreter/test-source-positions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698