src/interpreter/bytecode-peephole-optimizer.cc - Issue 2038323002: [interpreter] Filter expression positions at source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-peephole-optimizer.cc

Issue 2038323002: [interpreter] Filter expression positions at source. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth-0060-source-position-testing

Patch Set: Fix expression positions on StackCheck that this CL broke. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/interpreter/bytecode-array-builder.h ('K') | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/bytecode-pipeline.h » ('j') | test/cctest/interpreter/test-source-positions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/interpreter/bytecode-peephole-optimizer.cc

diff --git a/src/interpreter/bytecode-peephole-optimizer.cc b/src/interpreter/bytecode-peephole-optimizer.cc

index 881abf337b25a57d0961d7827f99232a922b6bd2..a16076407e92a3aa034b9d7b6530124e0f132c77 100644

--- a/src/interpreter/bytecode-peephole-optimizer.cc

+++ b/src/interpreter/bytecode-peephole-optimizer.cc

@@ -96,7 +96,7 @@ bool BytecodePeepholeOptimizer::LastBytecodePutsNameInAccumulator() const {

void BytecodePeepholeOptimizer::TryToRemoveLastExpressionPosition(

const BytecodeNode* const current) {

- if (current->source_info().is_statement() &&

+ if (current->source_info().is_valid() &&

last_.source_info().is_expression() &&

Bytecodes::IsWithoutExternalSideEffects(last_.bytecode())) {

// The last bytecode has been marked as expression. It has no