Using ResourceRequestBody as the type of HTTP body outside of //content.

content/browser/frame_host/navigation_controller_impl.cc

Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index fe5cdcd0f764db3adaa7b8a7932f6907fb31d66d..12a860dc19dd251fcb7214da8a340cf749ff6f98 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -669,7 +669,7 @@ void NavigationControllerImpl::LoadURLWithParams(const LoadURLParams& params) {
   switch (params.load_type) {
     case LOAD_TYPE_DEFAULT:
       break;
-    case LOAD_TYPE_BROWSER_INITIATED_HTTP_POST:
+    case LOAD_TYPE_HTTP_POST:
       if (!params.url.SchemeIs(url::kHttpScheme) &&
           !params.url.SchemeIs(url::kHttpsScheme)) {
         NOTREACHED() << "Http post load must use http(s) scheme.";

[Charlie Reis, 2016/06/09 22:38:16]

You determined recently that this check is invalid, right?  We might not need to
change it in this CL, but I bet we'll need to change it to support POSTs to/from
extension URLs, etc.

[Łukasz Anforowicz, 2016/06/10 19:20:50]

Thanks for raising this issue.  You're right - after this CL this DCHECK can
probably be trigerred for a renderer-initiated POST.  I think fixing this in a
separate CL should be fine (given the relatively benign fallback - cancelling
the navigation + especially since I also would want to add a test for this
scenario which won't be possible until after the next CL
[https://codereview.chromium.org/2004653002/]).  We'll probably also have to
chat more about a way to trigger this DCHECK from a test - I am not sure if a
web page can have an subframe with extension URI (and post to it).  And when
adding the test described above, we probably should also remove the
short-circuiting in chrome/renderer/chrome_content_renderer_client.cc: 1076:
ChromeContentRendererClient::ShouldFork.

FWIW, I've added an explicit TODO here.

[Charlie Reis, 2016/06/10 20:59:27]

Acknowledged.

@@ -768,10 +768,9 @@ void NavigationControllerImpl::LoadURLWithParams(const LoadURLParams& params) {
   switch (params.load_type) {
     case LOAD_TYPE_DEFAULT:
       break;
-    case LOAD_TYPE_BROWSER_INITIATED_HTTP_POST:
+    case LOAD_TYPE_HTTP_POST:
       entry->SetHasPostData(true);
-      entry->SetBrowserInitiatedPostData(
-          params.browser_initiated_post_data.get());
+      entry->SetPostData(params.post_data);
       break;
     case LOAD_TYPE_DATA:
       entry->SetBaseURLForDataURL(params.base_url_for_data_url);