Using ResourceRequestBody as the type of HTTP body outside of //content.

content/browser/frame_host/navigation_controller_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  *     (http://www.torchmobile.com/)
  *
@@ skipping 651 matching lines @@
     // unhandled, otherwise Telemetry can't tell if Navigation completed.
     if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
             cc::switches::kEnableGpuBenchmarking))
       return;
   }
 
   // Checks based on params.load_type.
   switch (params.load_type) {
     case LOAD_TYPE_DEFAULT:
       break;
-    case LOAD_TYPE_BROWSER_INITIATED_HTTP_POST:
+    case LOAD_TYPE_HTTP_POST:
       if (!params.url.SchemeIs(url::kHttpScheme) &&
           !params.url.SchemeIs(url::kHttpsScheme)) {
         NOTREACHED() << "Http post load must use http(s) scheme.";

[Charlie Reis, 2016/06/09 22:38:16]

You determined recently that this check is invalid, right?  We might not need to
change it in this CL, but I bet we'll need to change it to support POSTs to/from
extension URLs, etc.

[Łukasz Anforowicz, 2016/06/10 19:20:50]

Thanks for raising this issue.  You're right - after this CL this DCHECK can
probably be trigerred for a renderer-initiated POST.  I think fixing this in a
separate CL should be fine (given the relatively benign fallback - cancelling
the navigation + especially since I also would want to add a test for this
scenario which won't be possible until after the next CL
[https://codereview.chromium.org/2004653002/]).  We'll probably also have to
chat more about a way to trigger this DCHECK from a test - I am not sure if a
web page can have an subframe with extension URI (and post to it).  And when
adding the test described above, we probably should also remove the
short-circuiting in chrome/renderer/chrome_content_renderer_client.cc: 1076:
ChromeContentRendererClient::ShouldFork.

FWIW, I've added an explicit TODO here.

[Charlie Reis, 2016/06/10 20:59:27]

Acknowledged.

         return;
       }
       break;
     case LOAD_TYPE_DATA:
       if (!params.url.SchemeIs(url::kDataScheme)) {
         NOTREACHED() << "Data load must use data scheme.";
         return;
       }
       break;
     default:
@@ skipping 75 matching lines @@
     entry->set_intent_received_timestamp(
         base::TimeTicks() +
         base::TimeDelta::FromMilliseconds(params.intent_received_timestamp));
   }
   entry->set_has_user_gesture(params.has_user_gesture);
 #endif
 
   switch (params.load_type) {
     case LOAD_TYPE_DEFAULT:
       break;
-    case LOAD_TYPE_BROWSER_INITIATED_HTTP_POST:
+    case LOAD_TYPE_HTTP_POST:
       entry->SetHasPostData(true);
-      entry->SetBrowserInitiatedPostData(
-          params.browser_initiated_post_data.get());
+      entry->SetPostData(params.post_data);
       break;
     case LOAD_TYPE_DATA:
       entry->SetBaseURLForDataURL(params.base_url_for_data_url);
       entry->SetVirtualURL(params.virtual_url_for_data_url);
 #if defined(OS_ANDROID)
       entry->SetDataURLAsString(params.data_url_as_string);
 #endif
       entry->SetCanLoadLocalResources(params.can_load_local_resources);
       break;
     default:
@@ skipping 1275 matching lines @@
     }
   }
 }
 
 void NavigationControllerImpl::SetGetTimestampCallbackForTest(
     const base::Callback<base::Time()>& get_timestamp_callback) {
   get_timestamp_callback_ = get_timestamp_callback;
 }
 
 }  // namespace content