Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: components/web_contents_delegate_android/web_contents_delegate_android.cc

Issue 2038233002: Using ResourceRequestBody as the type of HTTP body outside of //content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make-resource-request-body-public
Patch Set: Rebasing... Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/web_contents_delegate_android/web_contents_delegate_android.cc
diff --git a/components/web_contents_delegate_android/web_contents_delegate_android.cc b/components/web_contents_delegate_android/web_contents_delegate_android.cc
index 9ecfc69fee3399c31be9941513d37c9397323d08..986470f83535fdd3ebba9be4d78259db328b4a33 100644
--- a/components/web_contents_delegate_android/web_contents_delegate_android.cc
+++ b/components/web_contents_delegate_android/web_contents_delegate_android.cc
@@ -90,14 +90,9 @@ WebContents* WebContentsDelegateAndroid::OpenURLFromTab(
ConvertUTF8ToJavaString(env, url.spec());
ScopedJavaLocalRef<jstring> extra_headers =
ConvertUTF8ToJavaString(env, params.extra_headers);
- ScopedJavaLocalRef<jbyteArray> post_data;
- if (params.uses_post &&
- params.browser_initiated_post_data.get() &&
- params.browser_initiated_post_data.get()->size()) {
- post_data = base::android::ToJavaByteArray(
- env, params.browser_initiated_post_data.get()->front_as<uint8_t>(),
- params.browser_initiated_post_data.get()->size());
- }
+ ScopedJavaLocalRef<jobject> post_data;
+ if (params.uses_post && params.post_data)
+ post_data = params.post_data->ToJavaObject(env);
Java_WebContentsDelegateAndroid_openNewTab(env,
obj.obj(),
java_url.obj(),
@@ -119,12 +114,9 @@ WebContents* WebContentsDelegateAndroid::OpenURLFromTab(
params.should_replace_current_entry;
load_params.is_renderer_initiated = params.is_renderer_initiated;
- // Only allows the browser-initiated navigation to use POST.
- if (params.uses_post && !params.is_renderer_initiated) {
- load_params.load_type =
- content::NavigationController::LOAD_TYPE_BROWSER_INITIATED_HTTP_POST;
- load_params.browser_initiated_post_data =
- params.browser_initiated_post_data;
+ if (params.uses_post) {
+ load_params.load_type = content::NavigationController::LOAD_TYPE_HTTP_POST;
+ load_params.post_data = params.post_data;
}
source->GetController().LoadURLWithParams(load_params);

Powered by Google App Engine
This is Rietveld 408576698