chrome/browser/ui/tab_contents/core_tab_helper.cc - Issue 2038233002: Using ResourceRequestBody as the type of HTTP body outside of //content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_contents/core_tab_helper.cc

Issue 2038233002: Using ResourceRequestBody as the type of HTTP body outside of //content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make-resource-request-body-public

Patch Set: Rebasing... Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_navigator_browsertest.cc ('K') | « chrome/browser/ui/browser_navigator_params.cc ('k') | chrome/test/base/ui_test_utils.cc » ('j') | content/browser/frame_host/navigation_controller_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tab_contents/core_tab_helper.cc

diff --git a/chrome/browser/ui/tab_contents/core_tab_helper.cc b/chrome/browser/ui/tab_contents/core_tab_helper.cc

index df57665f89971bd2573a71a5fbf4c0ec2270da42..94b92acdcd6d943b0c018d297ba8827109153d89 100644

--- a/chrome/browser/ui/tab_contents/core_tab_helper.cc

+++ b/chrome/browser/ui/tab_contents/core_tab_helper.cc

@@ -350,12 +350,12 @@ void CoreTabHelper::DoSearchByImageInNewTab(const GURL& src_url,

result, content::Referrer(), NEW_FOREGROUND_TAB,

ui::PAGE_TRANSITION_LINK, false);

const std::string& content_type = post_content.first;

- std::string* post_data = &post_content.second;

- if (!post_data->empty()) {

+ const std::string& post_data = post_content.second;

+ if (!post_data.empty()) {

DCHECK(!content_type.empty());

open_url_params.uses_post = true;

- open_url_params.browser_initiated_post_data =

- base::RefCountedString::TakeString(post_data);

+ open_url_params.post_data =

+ content::ResourceRequestBody::CreateFromBytes(post_data);

open_url_params.extra_headers += base::StringPrintf(

"%s: %s\r\n", net::HttpRequestHeaders::kContentType,

content_type.c_str());