Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: mash/browser/browser.cc

Issue 2038143003: Support link hovering. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clean
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mash/webtest/webtest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mash/browser/browser.cc
diff --git a/mash/browser/browser.cc b/mash/browser/browser.cc
index 0fcb9ddb15b09fc32c74fc37d0b96bfdc39a69d6..c555c9550afc855a694eefb48578000f9232f017 100644
--- a/mash/browser/browser.cc
+++ b/mash/browser/browser.cc
@@ -152,6 +152,7 @@ class UI : public views::WidgetDelegateView,
AddChildView(progress_bar_);
AddChildView(debug_view_);
debug_view_->set_view(view_.get());
+ view_->SetResizerSize(gfx::Size(16, 16));
}
~UI() override { browser_->RemoveWindow(GetWidget()); }
@@ -293,13 +294,20 @@ class UI : public views::WidgetDelegateView,
bool can_go_forward) override {
EnableButton(back_button_, can_go_back);
EnableButton(forward_button_, can_go_forward);
- prompt_->SetText(base::UTF8ToUTF16(url.spec()));
+ current_url_ = url;
+ prompt_->SetText(base::UTF8ToUTF16(current_url_.spec()));
current_title_ = base::UTF8ToUTF16(title.get());
GetWidget()->UpdateWindowTitle();
}
void LoadProgressChanged(double progress) override {
progress_bar_->SetProgress(progress);
}
+ void UpdateHoverURL(const GURL& url) override {
+ if (url.is_valid())
+ prompt_->SetText(base::UTF8ToUTF16(url.spec()));
+ else
+ prompt_->SetText(base::UTF8ToUTF16(current_url_.spec()));
+ }
void ViewCreated(navigation::mojom::ViewPtr view,
navigation::mojom::ViewClientRequest request,
bool is_popup,
@@ -340,6 +348,7 @@ class UI : public views::WidgetDelegateView,
bool is_loading_ = false;
base::string16 current_title_;
+ GURL current_url_;
bool showing_debug_view_ = false;
« no previous file with comments | « no previous file | mash/webtest/webtest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698