Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2038093003: Refactor accessible focus ring code so the layers are animation observers. (Closed)

Created:
4 years, 6 months ago by dmazzoni
Modified:
4 years, 6 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@improve_highlights
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor accessible focus ring code so the layers are animation observers. I'd like to make more of the focus ring layers animate, so it will be simpler if the layers are animation observers and keep track of their own compositor, rather than storing them all in AccessibilityFocusRingController. I'm assuming it's not too expensive to have OnAnimationStep() called for a layer that doesn't need to animate all the time. If that's not true, this refactoring would make it easier to add StartAnimating and StopAnimating methods to FocusRingLayer for better efficiency. BUG=314889 Committed: https://crrev.com/82a45a85f0b2a9292d9524e90cc82ee3da68d876 Cr-Commit-Position: refs/heads/master@{#397825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -97 lines) Patch
M chrome/browser/chromeos/ui/accessibility_cursor_ring_layer.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/ui/accessibility_focus_ring_controller.h View 3 chunks +2 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc View 8 chunks +4 lines, -60 lines 0 comments Download
M chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/ui/focus_ring_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/ui/focus_ring_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/ui/focus_ring_layer.h View 7 chunks +20 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/ui/focus_ring_layer.cc View 4 chunks +45 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
dmazzoni
4 years, 6 months ago (2016-06-03 19:32:52 UTC) #2
xiyuan
lgtm
4 years, 6 months ago (2016-06-03 19:45:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038093003/1
4 years, 6 months ago (2016-06-03 20:53:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 22:33:59 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 22:35:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82a45a85f0b2a9292d9524e90cc82ee3da68d876
Cr-Commit-Position: refs/heads/master@{#397825}

Powered by Google App Engine
This is Rietveld 408576698