Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2036343003: Chrome OS highlighting: show only focus or caret, never both. (Closed)

Created:
4 years, 6 months ago by dmazzoni
Modified:
4 years, 6 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chrome OS highlighting: show only focus or caret, never both. When the text caret is visible, show that highlight, otherwise if something has focus, show the focus highlight - never both since they too often overlap. BUG=314889 Committed: https://crrev.com/783d36f567c7a36fa829b011b26510e336a3260c Cr-Commit-Position: refs/heads/master@{#397796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -22 lines) Patch
M chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_highlight_manager.cc View 3 chunks +27 lines, -22 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
dmazzoni
4 years, 6 months ago (2016-06-03 18:14:41 UTC) #2
xiyuan
lgtm
4 years, 6 months ago (2016-06-03 18:26:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036343003/1
4 years, 6 months ago (2016-06-03 19:32:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 20:38:42 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 20:40:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/783d36f567c7a36fa829b011b26510e336a3260c
Cr-Commit-Position: refs/heads/master@{#397796}

Powered by Google App Engine
This is Rietveld 408576698