Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2038033002: Revert "Add package-config tests where test is running in Isolate.spawn-isolates." (Closed)

Created:
4 years, 6 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 6 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert and reapply "Add package-config tests where test is running in Isolate.spawn-isolates." Running a new process doesn't correctly pass empty command line parameters on Windows. Committed: https://github.com/dart-lang/sdk/commit/151d1b67961d3be2a7dc8f5f76948ccbfe045fcb R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/2d8e63e9859a388cd1a3847ef5d20a32ace52c6c Committed: https://github.com/dart-lang/sdk/commit/c7e601c90dabe37daa9e477c29d87d67def3e43e

Patch Set 1 #

Patch Set 2 : Revert again, more windows failures #

Patch Set 3 : Base for reapply #

Patch Set 4 : Fix the bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+710 lines, -230 lines) Patch
M runtime/bin/builtin.dart View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/packages_file_test.dart View 1 2 9 chunks +704 lines, -227 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as 151d1b67961d3be2a7dc8f5f76948ccbfe045fcb (presubmit successful).
4 years, 6 months ago (2016-06-03 13:34:56 UTC) #2
Lasse Reichstein Nielsen
TBR
4 years, 6 months ago (2016-06-03 13:35:14 UTC) #4
floitsch
LGTM.
4 years, 6 months ago (2016-06-03 15:07:11 UTC) #5
Lasse Reichstein Nielsen
Committed patchset #2 (id:20001) manually as 2d8e63e9859a388cd1a3847ef5d20a32ace52c6c (presubmit successful).
4 years, 6 months ago (2016-06-03 15:12:36 UTC) #7
Lasse Reichstein Nielsen
4 years, 6 months ago (2016-06-06 06:47:23 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
c7e601c90dabe37daa9e477c29d87d67def3e43e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698