gl: Check format is valid given an internal format.

gl: Check format is valid given an internal format.

GLImageOzoneNativePixmap used to check that format and internal format
were valid, but didn't check that they were compatible.

This CL restricts the valid internalformats given the buffer format
used to initialize the image (e.g: it's now prohibited to initialize with
an R8 buffer an GL_RGBA image).

TEST='gl_unittests --gtest_also_run_disabled_tests' on samus

Committed: https://crrev.com/071378ae67d61ec709501b9647daa881240b25aa
Cr-Commit-Position: refs/heads/master@{#397876}

[Daniele Castagna, 2016-06-03 23:21:13]

dcastagna@chromium.org changed reviewers:
+ reveman@chromium.org

[reveman, 2016-06-03 23:33:01]

lgtm with a small suggestion

https://codereview.chromium.org/2037983003/diff/1/ui/gl/gl_image_ozone_native...
File ui/gl/gl_image_ozone_native_pixmap.cc (right):

https://codereview.chromium.org/2037983003/diff/1/ui/gl/gl_image_ozone_native...
ui/gl/gl_image_ozone_native_pixmap.cc:24: case GL_RGB:
maybe we should be even more restrictive here and not allow RGBA to be bound to
RGB until we actually need that.

[Daniele Castagna, 2016-06-03 23:33:44]

Description was changed from

==========
gl: Check format is valid given an internal format.

GLImageOzoneNativePixmap used to check that format and internal format
were valid, but didn't check that they were compatible.

This CL restricts the valid internalformats given the buffer format
used to initialize the image (e.g: it's now prohibited to initialize with
an R8 buffer an GL_RGBA image).

TEST=/tmp/gl_unittests --gtest_also_run_disabled_tests on samus
==========

to

==========
gl: Check format is valid given an internal format.

GLImageOzoneNativePixmap used to check that format and internal format
were valid, but didn't check that they were compatible.

This CL restricts the valid internalformats given the buffer format
used to initialize the image (e.g: it's now prohibited to initialize with
an R8 buffer an GL_RGBA image).

TEST='gl_unittests --gtest_also_run_disabled_tests' on samus
==========

[Daniele Castagna, 2016-06-03 23:45:29]

https://codereview.chromium.org/2037983003/diff/1/ui/gl/gl_image_ozone_native...
File ui/gl/gl_image_ozone_native_pixmap.cc (right):

https://codereview.chromium.org/2037983003/diff/1/ui/gl/gl_image_ozone_native...
ui/gl/gl_image_ozone_native_pixmap.cc:24: case GL_RGB:
On 2016/06/03 at 23:33:01, reveman wrote:
> maybe we should be even more restrictive here and not allow RGBA to be bound
to RGB until we actually need that.

Made validation as restrictive as possible.

[Daniele Castagna, 2016-06-04 00:05:18]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2016-06-04 00:05:18]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2037983003/#ps20001
(title: "Make validation as restrictive as possible.")

[commit-bot: I haz the power, 2016-06-04 00:05:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2037983003/20001

[commit-bot: I haz the power, 2016-06-04 01:03:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-04 01:04:55]

Description was changed from

==========
gl: Check format is valid given an internal format.

GLImageOzoneNativePixmap used to check that format and internal format
were valid, but didn't check that they were compatible.

This CL restricts the valid internalformats given the buffer format
used to initialize the image (e.g: it's now prohibited to initialize with
an R8 buffer an GL_RGBA image).

TEST='gl_unittests --gtest_also_run_disabled_tests' on samus
==========

to

==========
gl: Check format is valid given an internal format.

GLImageOzoneNativePixmap used to check that format and internal format
were valid, but didn't check that they were compatible.

This CL restricts the valid internalformats given the buffer format
used to initialize the image (e.g: it's now prohibited to initialize with
an R8 buffer an GL_RGBA image).

TEST='gl_unittests --gtest_also_run_disabled_tests' on samus

Committed: https://crrev.com/071378ae67d61ec709501b9647daa881240b25aa
Cr-Commit-Position: refs/heads/master@{#397876}
==========

[commit-bot: I haz the power, 2016-06-04 01:04:56]

Patchset 2 (id:??) landed as
https://crrev.com/071378ae67d61ec709501b9647daa881240b25aa
Cr-Commit-Position: refs/heads/master@{#397876}