ui/gl/gl_image_ozone_native_pixmap_unittest.cc - Issue 2037983003: gl: Check format is valid given an internal format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gl/gl_image_ozone_native_pixmap_unittest.cc

Issue 2037983003: gl: Check format is valid given an internal format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make validation as restrictive as possible. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gl/gl_image_ozone_native_pixmap_unittest.cc

diff --git a/ui/gl/gl_image_ozone_native_pixmap_unittest.cc b/ui/gl/gl_image_ozone_native_pixmap_unittest.cc

index d0877ae799f446db206601810e2a711c10deb866..d1360644ca9dbf58b56b9fcfffa9774c1d23f91a 100644

--- a/ui/gl/gl_image_ozone_native_pixmap_unittest.cc

+++ b/ui/gl/gl_image_ozone_native_pixmap_unittest.cc

@@ -44,8 +44,8 @@ class GLImageOzoneNativePixmapTestDelegate {

client_pixmap->Unmap();

}

- scoped_refptr<GLImageOzoneNativePixmap> image(

- new GLImageOzoneNativePixmap(size, GL_RGBA));

+ scoped_refptr<GLImageOzoneNativePixmap> image(new GLImageOzoneNativePixmap(

+ size, GLImageOzoneNativePixmap::GetInternalFormatForTesting(format)));

EXPECT_TRUE(image->Initialize(pixmap.get(), pixmap->GetBufferFormat()));

return image;

}

« no previous file with comments | « ui/gl/gl_image_ozone_native_pixmap.cc ('k') | no next file » | no next file with comments »