Percent height content should respect the fixed height of its containing cell

Percent height content should respect the fixed height of its containing cell

When an element in a cell has a percent height and the cell has a fixed height we
currently let the element ignore the height on the cell and instead let its content
determine the height of the cell (and the row).

Instead we should follow FF/Presto/Edge and the rendering agreed on the WG list
and let the element calculate itself as a percentage of its parent, the cell's
height.

https://lists.w3.org/Archives/Public/www-style/2015Mar/0101.html

BUG=465096, 468699
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192000

[rhogan, 2015-03-16 10:34:34]

robhogan@gmail.com changed reviewers:
+ dsinclair@chromium.org

[rhogan, 2015-03-16 10:34:34]

dsinclair: got time to take a look?

[dsinclair, 2015-03-16 14:12:06]

dsinclair@chromium.org changed reviewers:
+ jchaffraix@chromium.org, leviw@chromium.org

[dsinclair, 2015-03-16 14:12:07]

This seems good to me but I'd like to get jchaffraix@ or leviw@ to take a look.

[dsinclair, 2015-03-16 14:12:07]

This seems good to me but I'd like to get jchaffraix@ or leviw@ to take a look.

[Julien - ping for review, 2015-03-16 18:39:54]

lgtm but the description should be wrapped at <80 (72 is a good number for that)

https://codereview.chromium.org/992483002/diff/40001/Source/core/layout/Layou...
File Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/992483002/diff/40001/Source/core/layout/Layou...
Source/core/layout/LayoutBox.cpp:2477: includeBorderPadding = true;
This really looks like it should be refactored out of the branches:

bool includeBorderPadding = isTable() || isTableCell();

https://codereview.chromium.org/992483002/diff/40001/Source/core/layout/Layou...
Source/core/layout/LayoutBox.cpp:2534: // crbug.com/467378: Doing this for
content inside tables cells is wrong, it should fill
FIXME? TODO?

[rhogan, 2015-03-17 09:24:54]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2015-03-17 09:24:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
jchaffraix@chromium.org
Link to the patchset: https://codereview.chromium.org/992483002/#ps60001 (title:
"UPdated")

[commit-bot: I haz the power, 2015-03-17 09:25:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/992483002/60001

[commit-bot: I haz the power, 2015-03-17 10:59:27]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192000

[rhogan, 2015-03-20 18:49:31]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1028773002/ by robhogan@gmail.com.

The reason for reverting is: Broke Hangouts.