Fix chrome_telemetry_build's GN dependencies for Mac OS X.

Fix chrome_telemetry_build's GN dependencies for Mac OS X.

The previous bug workaround for Issue 536192 should no longer be
necessary.

BUG=599776

[caseq, 2016-06-04 01:14:57]

caseq@chromium.org changed reviewers:
+ aiolos@chromium.org, dpranke@chromium.org, kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-06-04 01:15:41]

LGTM

We tested this locally with a GN build on Mac OS X and it works.

[Ken Russell (switch to Gerrit), 2016-06-04 01:15:50]

The CQ bit was checked by kbr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-04 01:16:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2037773005/1

[commit-bot: I haz the power, 2016-06-04 02:27:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-04 02:27:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Russell (switch to Gerrit), 2016-06-04 02:30:49]

https://codereview.chromium.org/2037773005/diff/1/tools/perf/chrome_telemetry...
File tools/perf/chrome_telemetry_build/BUILD.gn (left):

https://codereview.chromium.org/2037773005/diff/1/tools/perf/chrome_telemetry...
tools/perf/chrome_telemetry_build/BUILD.gn:45: data_deps += [
"//chrome:chrome_initial" ]
Dirk: it looks like this is still needed on Linux. See failing try job
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
. Is that expected at this point?

[Dirk Pranke, 2016-06-04 22:57:27]

https://codereview.chromium.org/2037773005/diff/1/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/2037773005/diff/1/chrome/BUILD.gn#newcode59
chrome/BUILD.gn:59: group("chrome") {
looks like you need to add a data_deps var here as well.

https://codereview.chromium.org/2037773005/diff/1/tools/perf/chrome_telemetry...
File tools/perf/chrome_telemetry_build/BUILD.gn (left):

https://codereview.chromium.org/2037773005/diff/1/tools/perf/chrome_telemetry...
tools/perf/chrome_telemetry_build/BUILD.gn:45: data_deps += [
"//chrome:chrome_initial" ]
On 2016/06/04 02:30:49, Ken Russell wrote:
> Dirk: it looks like this is still needed on Linux. See failing try job
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
> . Is that expected at this point?

No, I wasn't expecting that, but I guess I'm not all that surprised, either ;).

[Ken Russell (switch to Gerrit), 2016-06-07 04:35:07]

caseq: sorry, I'll take this over. (I don't have permission to upload additional
patch sets to this CL)

[Ken Russell (switch to Gerrit), 2016-06-07 04:36:38]

Closing in favor of https://codereview.chromium.org/2048563002 .

[caseq, 2016-06-07 20:35:28]

On 2016/06/07 04:35:07, Ken Russell wrote:
> caseq: sorry, I'll take this over. (I don't have permission to upload
additional
> patch sets to this CL)

sure, no problem!

[caseq, 2016-06-07 20:35:34]

Description was changed from

==========
Fix chrome_telemetry_build's GN dependencies for Mac OS X.

The previous bug workaround for Issue 536192 should no longer be
necessary.

BUG=599776
==========

to

==========
Fix chrome_telemetry_build's GN dependencies for Mac OS X.

The previous bug workaround for Issue 536192 should no longer be
necessary.

BUG=599776
==========