Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2037773005: Fix chrome_telemetry_build's GN dependencies for Mac OS X. (Closed)

Created:
4 years, 6 months ago by caseq
Modified:
4 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix chrome_telemetry_build's GN dependencies for Mac OS X. The previous bug workaround for Issue 536192 should no longer be necessary. BUG=599776

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M chrome/BUILD.gn View 1 chunk +3 lines, -0 lines 1 comment Download
M tools/perf/chrome_telemetry_build/BUILD.gn View 1 chunk +1 line, -7 lines 2 comments Download

Messages

Total messages: 13 (4 generated)
caseq
4 years, 6 months ago (2016-06-04 01:14:58 UTC) #2
Ken Russell (switch to Gerrit)
LGTM We tested this locally with a GN build on Mac OS X and it ...
4 years, 6 months ago (2016-06-04 01:15:41 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037773005/1
4 years, 6 months ago (2016-06-04 01:16:09 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/241308)
4 years, 6 months ago (2016-06-04 02:27:16 UTC) #7
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/2037773005/diff/1/tools/perf/chrome_telemetry_build/BUILD.gn File tools/perf/chrome_telemetry_build/BUILD.gn (left): https://codereview.chromium.org/2037773005/diff/1/tools/perf/chrome_telemetry_build/BUILD.gn#oldcode45 tools/perf/chrome_telemetry_build/BUILD.gn:45: data_deps += [ "//chrome:chrome_initial" ] Dirk: it looks like ...
4 years, 6 months ago (2016-06-04 02:30:49 UTC) #8
Dirk Pranke
https://codereview.chromium.org/2037773005/diff/1/chrome/BUILD.gn File chrome/BUILD.gn (right): https://codereview.chromium.org/2037773005/diff/1/chrome/BUILD.gn#newcode59 chrome/BUILD.gn:59: group("chrome") { looks like you need to add a ...
4 years, 6 months ago (2016-06-04 22:57:27 UTC) #9
Ken Russell (switch to Gerrit)
caseq: sorry, I'll take this over. (I don't have permission to upload additional patch sets ...
4 years, 6 months ago (2016-06-07 04:35:07 UTC) #10
Ken Russell (switch to Gerrit)
Closing in favor of https://codereview.chromium.org/2048563002 .
4 years, 6 months ago (2016-06-07 04:36:38 UTC) #11
caseq
4 years, 6 months ago (2016-06-07 20:35:28 UTC) #12
On 2016/06/07 04:35:07, Ken Russell wrote:
> caseq: sorry, I'll take this over. (I don't have permission to upload
additional
> patch sets to this CL)

sure, no problem!

Powered by Google App Engine
This is Rietveld 408576698