extensions/browser/api/storage/storage_frontend.cc - Issue 2037703004: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/storage/storage_frontend.cc

Issue 2037703004: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/storage/settings_test_util.cc ('k') | extensions/browser/api/web_request/upload_data_presenter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/storage/storage_frontend.cc

diff --git a/extensions/browser/api/storage/storage_frontend.cc b/extensions/browser/api/storage/storage_frontend.cc

index 1e60c44b74743ec05e356c301c4c89d1c3089eaa..0f1ceed3dcafb014dabdf3b6325b3ec3696eacc8 100644

--- a/extensions/browser/api/storage/storage_frontend.cc

+++ b/extensions/browser/api/storage/storage_frontend.cc

@@ -49,8 +49,7 @@ class DefaultObserver : public SettingsObserver {

// string-based event payloads is removed. http://crbug.com/136045

std::unique_ptr<base::ListValue> args(new base::ListValue());

args->Append(base::JSONReader::Read(change_json));

- args->Append(new base::StringValue(settings_namespace::ToString(

- settings_namespace)));

+ args->AppendString(settings_namespace::ToString(settings_namespace));

std::unique_ptr<Event> event(new Event(events::STORAGE_ON_CHANGED,

api::storage::OnChanged::kEventName,

std::move(args)));