Chromium Code Reviews| Index: chrome/common/safe_browsing/permission_report.proto |
| diff --git a/chrome/common/safe_browsing/permission_report.proto b/chrome/common/safe_browsing/permission_report.proto |
| index 59dc519e40172ecf2d29e4e4cadd0167b282f421..070685ded4f2b774a123e90fd3f6de9d86ddce9c 100644 |
| --- a/chrome/common/safe_browsing/permission_report.proto |
| +++ b/chrome/common/safe_browsing/permission_report.proto |
| @@ -34,9 +34,7 @@ message PermissionReport { |
| optional SourceUI source_ui = 6; |
| // The relevant field trials enabled for this report. |
| - // TODO(stefanocs): Update field_trials field to store hashes instead of |
| - // string. |
| - repeated string field_trials = 7; |
| + repeated FieldTrial field_trials = 7; |
| // Platform |
| enum PlatformType { |
| @@ -89,4 +87,21 @@ message PermissionReport { |
| AUDIO_CAPTURE = 8; |
| VIDEO_CAPTURE = 9; |
| } |
| + |
| + // Description of a field trial or experiment that the user is currently |
| + // enrolled in. All metrics reported in this upload can potentially be |
| + // influenced by the field trial. |
| + // |
| + // This message is copied from |
| + // //src/components/metrics/proto/system_profile.proto |
| + // since the file cannot be imported by the current build system. |
|
raymes
2016/06/15 02:27:02
I think we can get rid of this part of the paragra
stefanocs
2016/06/15 05:43:08
Done.
|
| + message FieldTrial { |
| + // The name of the field trial, as a 32-bit identifier. Currently, the |
| + // identifier is a hash of the field trial's name. |
| + optional fixed32 name_id = 1; |
| + |
| + // The user's group within the field trial, as a 32-bit identifier. |
| + // Currently, the identifier is a hash of the group's name. |
| + optional fixed32 group_id = 2; |
| + } |
| } |