Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Side by Side Diff: chrome/common/safe_browsing/permission_report.proto

Issue 2037693004: Change field_trials type to hashes in permission report proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Protocol buffer for permission reports sent to the Safe Browsing client-side 5 // Protocol buffer for permission reports sent to the Safe Browsing client-side
6 // detection (CSD) frontends. This should stay in sync with the Safe Browsing 6 // detection (CSD) frontends. This should stay in sync with the Safe Browsing
7 // server-side protocol buffer. 7 // server-side protocol buffer.
8 8
9 syntax = "proto2"; 9 syntax = "proto2";
10 10
(...skipping 16 matching lines...) Expand all
27 // When the request was initiated. 27 // When the request was initiated.
28 repeated RequestTrigger request_trigger = 4; 28 repeated RequestTrigger request_trigger = 4;
29 29
30 // The action the user took. Required. 30 // The action the user took. Required.
31 optional Action action = 5; 31 optional Action action = 5;
32 32
33 // The UI used to complete the action. 33 // The UI used to complete the action.
34 optional SourceUI source_ui = 6; 34 optional SourceUI source_ui = 6;
35 35
36 // The relevant field trials enabled for this report. 36 // The relevant field trials enabled for this report.
37 // TODO(stefanocs): Update field_trials field to store hashes instead of 37 repeated FieldTrial field_trials = 7;
38 // string.
39 repeated string field_trials = 7;
40 38
41 // Platform 39 // Platform
42 enum PlatformType { 40 enum PlatformType {
43 PLATFORM_TYPE_UNSPECIFIED = 0; 41 PLATFORM_TYPE_UNSPECIFIED = 0;
44 DESKTOP_PLATFORM = 1; 42 DESKTOP_PLATFORM = 1;
45 ANDROID_PLATFORM = 2; 43 ANDROID_PLATFORM = 2;
46 } 44 }
47 45
48 // Various request triggers we want to record, e.g. on page load. 46 // Various request triggers we want to record, e.g. on page load.
49 enum RequestTrigger { 47 enum RequestTrigger {
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 MIDI_SYSEX = 1; 80 MIDI_SYSEX = 1;
83 PUSH_MESSAGING = 2; 81 PUSH_MESSAGING = 2;
84 NOTIFICATIONS = 3; 82 NOTIFICATIONS = 3;
85 GEOLOCATION = 4; 83 GEOLOCATION = 4;
86 PROTECTED_MEDIA_IDENTIFIER = 5; 84 PROTECTED_MEDIA_IDENTIFIER = 5;
87 MIDI = 6; 85 MIDI = 6;
88 DURABLE_STORAGE = 7; 86 DURABLE_STORAGE = 7;
89 AUDIO_CAPTURE = 8; 87 AUDIO_CAPTURE = 8;
90 VIDEO_CAPTURE = 9; 88 VIDEO_CAPTURE = 9;
91 } 89 }
90
91 // Description of a field trial or experiment that the user is currently
92 // enrolled in. All metrics reported in this upload can potentially be
93 // influenced by the field trial.
94 //
95 // This message is copied from
96 // //src/components/metrics/proto/system_profile.proto
97 // since the file cannot be imported by the current build system.
raymes 2016/06/15 02:27:02 I think we can get rid of this part of the paragra
stefanocs 2016/06/15 05:43:08 Done.
98 message FieldTrial {
99 // The name of the field trial, as a 32-bit identifier. Currently, the
100 // identifier is a hash of the field trial's name.
101 optional fixed32 name_id = 1;
102
103 // The user's group within the field trial, as a 32-bit identifier.
104 // Currently, the identifier is a hash of the group's name.
105 optional fixed32 group_id = 2;
106 }
92 } 107 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698