Issue 2037573005: Clean up C-Style casts in CBC_CodeBase and subclasses

Issue 2037573005: Clean up C-Style casts in CBC_CodeBase and subclasses (Closed)

Created:
4 years, 6 months ago by Tom Sepez

Modified:
4 years, 6 months ago

Reviewers:
Lei Zhang, dsinclair

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Clean up C-Style casts in CBC_CodeBase and subclasses Make the parent class own the reader/writer via unique_ptrs. De-virtualize some methods with no overrides. Committed: https://pdfium.googlesource.com/pdfium/+/52d78564a61fad5d435f3c95a3a6c0df142e50cf

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+173 lines, -188 lines)			Patch
M	xfa/fxbarcode/cbc_codabar.cpp	View	4 chunks	+21 lines, -21 lines	0 comments	Download
M	xfa/fxbarcode/cbc_code128.cpp	View	3 chunks	+14 lines, -16 lines	0 comments	Download
M	xfa/fxbarcode/cbc_code39.cpp	View	5 chunks	+23 lines, -27 lines	0 comments	Download
M	xfa/fxbarcode/cbc_codebase.h	View	3 chunks	+12 lines, -11 lines	0 comments	Download
M	xfa/fxbarcode/cbc_codebase.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	xfa/fxbarcode/cbc_datamatrix.cpp	View	3 chunks	+11 lines, -12 lines	0 comments	Download
M	xfa/fxbarcode/cbc_ean13.cpp	View	3 chunks	+11 lines, -15 lines	0 comments	Download
M	xfa/fxbarcode/cbc_ean8.cpp	View	3 chunks	+11 lines, -15 lines	0 comments	Download
M	xfa/fxbarcode/cbc_onecode.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	xfa/fxbarcode/cbc_onecode.cpp	View	1 chunk	+16 lines, -14 lines	0 comments	Download
M	xfa/fxbarcode/cbc_pdf417i.cpp	View	3 chunks	+13 lines, -14 lines	0 comments	Download
M	xfa/fxbarcode/cbc_qrcode.cpp	View	3 chunks	+19 lines, -22 lines	0 comments	Download
M	xfa/fxbarcode/cbc_upca.cpp	View	3 chunks	+18 lines, -19 lines	0 comments	Download

Total messages: 10 (5 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037573005/1

4 years, 6 months ago (2016-06-06 19:47:47 UTC) #8

commit-bot: I haz the power

4 years, 6 months ago (2016-06-06 19:57:57 UTC) #10

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/52d78564a61fad5d435f3c95a3a6c0df142e...