Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1912)

Unified Diff: xfa/fxbarcode/cbc_onecode.cpp

Issue 2037573005: Clean up C-Style casts in CBC_CodeBase and subclasses (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fxbarcode/cbc_onecode.h ('k') | xfa/fxbarcode/cbc_pdf417i.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fxbarcode/cbc_onecode.cpp
diff --git a/xfa/fxbarcode/cbc_onecode.cpp b/xfa/fxbarcode/cbc_onecode.cpp
index f5e1a3960a0fc0459efebf082517a3090bdd1d5c..b435a5901294a170406fb1d99bd12947575fa2c3 100644
--- a/xfa/fxbarcode/cbc_onecode.cpp
+++ b/xfa/fxbarcode/cbc_onecode.cpp
@@ -23,55 +23,57 @@
#include "xfa/fxbarcode/oned/BC_OneDimWriter.h"
-CBC_OneCode::CBC_OneCode() {}
+CBC_OneCode::CBC_OneCode(CBC_Reader* pReader, CBC_Writer* pWriter)
+ : CBC_CodeBase(pReader, pWriter) {}
CBC_OneCode::~CBC_OneCode() {}
FX_BOOL CBC_OneCode::CheckContentValidity(const CFX_WideStringC& contents) {
- if (m_pBCWriter)
- return ((CBC_OneDimWriter*)m_pBCWriter)->CheckContentValidity(contents);
- return FALSE;
+ return m_pBCWriter &&
+ static_cast<CBC_OneDimWriter*>(m_pBCWriter.get())
+ ->CheckContentValidity(contents);
}
CFX_WideString CBC_OneCode::FilterContents(const CFX_WideStringC& contents) {
- CFX_WideString tmp;
if (!m_pBCWriter)
- return tmp;
- return ((CBC_OneDimWriter*)m_pBCWriter)->FilterContents(contents);
+ return CFX_WideString();
+ return static_cast<CBC_OneDimWriter*>(m_pBCWriter.get())
+ ->FilterContents(contents);
}
void CBC_OneCode::SetPrintChecksum(FX_BOOL checksum) {
if (m_pBCWriter)
- ((CBC_OneDimWriter*)m_pBCWriter)->SetPrintChecksum(checksum);
+ static_cast<CBC_OneDimWriter*>(m_pBCWriter.get())
+ ->SetPrintChecksum(checksum);
}
void CBC_OneCode::SetDataLength(int32_t length) {
if (m_pBCWriter)
- ((CBC_OneDimWriter*)m_pBCWriter)->SetDataLength(length);
+ static_cast<CBC_OneDimWriter*>(m_pBCWriter.get())->SetDataLength(length);
}
void CBC_OneCode::SetCalChecksum(FX_BOOL calc) {
if (m_pBCWriter)
- ((CBC_OneDimWriter*)m_pBCWriter)->SetCalcChecksum(calc);
+ static_cast<CBC_OneDimWriter*>(m_pBCWriter.get())->SetCalcChecksum(calc);
}
FX_BOOL CBC_OneCode::SetFont(CFX_Font* cFont) {
if (m_pBCWriter)
- return ((CBC_OneDimWriter*)m_pBCWriter)->SetFont(cFont);
+ return static_cast<CBC_OneDimWriter*>(m_pBCWriter.get())->SetFont(cFont);
return FALSE;
}
void CBC_OneCode::SetFontSize(FX_FLOAT size) {
if (m_pBCWriter)
- ((CBC_OneDimWriter*)m_pBCWriter)->SetFontSize(size);
+ static_cast<CBC_OneDimWriter*>(m_pBCWriter.get())->SetFontSize(size);
}
void CBC_OneCode::SetFontStyle(int32_t style) {
if (m_pBCWriter)
- ((CBC_OneDimWriter*)m_pBCWriter)->SetFontStyle(style);
+ static_cast<CBC_OneDimWriter*>(m_pBCWriter.get())->SetFontStyle(style);
}
void CBC_OneCode::SetFontColor(FX_ARGB color) {
if (m_pBCWriter)
- ((CBC_OneDimWriter*)m_pBCWriter)->SetFontColor(color);
+ static_cast<CBC_OneDimWriter*>(m_pBCWriter.get())->SetFontColor(color);
}
« no previous file with comments | « xfa/fxbarcode/cbc_onecode.h ('k') | xfa/fxbarcode/cbc_pdf417i.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698