Empty SVG viewbox should be treated invalid

third_party/WebKit/Source/core/svg/SVGRect.cpp

Index: third_party/WebKit/Source/core/svg/SVGRect.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGRect.cpp b/third_party/WebKit/Source/core/svg/SVGRect.cpp
index 37149e65f89e358ea3ff12f8e844236cefdcdc8a..c00119f29196007668372dbadb04f7de45d69df6 100644
--- a/third_party/WebKit/Source/core/svg/SVGRect.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGRect.cpp
@@ -72,15 +72,9 @@ SVGParsingError SVGRect::setValueAsString(const String& string)
 {
     setInvalid();
 
-    if (string.isNull())
+    if (string.isNull() || string.isEmpty())

[fs, 2016/06/03 10:42:51]

isEmpty() would be an error, so probably not return NoError.

(Probably rather SVGParsingError(SVGParseStatus::ExpectedNumber, 0) or so.)

[Shanmuga Pandi, 2016/06/03 13:09:31]

Done.

         return SVGParseStatus::NoError;
 
-    if (string.isEmpty()) {
-        m_value = FloatRect(0.0f, 0.0f, 0.0f, 0.0f);
-        m_isValid = true;
-        return SVGParseStatus::NoError;
-    }
-
     if (string.is8Bit()) {
         const LChar* ptr = string.characters8();
         const LChar* end = ptr + string.length();