Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2037553002: INPUT pattern attribute: Enable "unicode" flag. (Closed)

Created:
4 years, 6 months ago by tkent
Modified:
4 years, 6 months ago
Reviewers:
keishi, Yuki
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

INPUT pattern attribute: Enable "unicode" flag. Pass UTF16 flag to ScriptRegexp. Additional changes: * ScriptRegexp records an exception message from V8 in order to show friendly console errors. * BaseTextInputType caches ScripRegexp to avoid to show same console errors repeatedly. * Move BaseTextInputType constructor and destructor to .cpp file to avoid to include ScriptRegexp.h in BaseTextInputType.h. Intent-to-ship: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/XUNMtri0tI4/qIsHgTWNAQAJ BUG=535441 Committed: https://crrev.com/bf29fb367d40c5b6fc9f41a1c268daa78e4aa031 Cr-Commit-Position: refs/heads/master@{#397352}

Patch Set 1 #

Patch Set 2 : Add a comment about |mutable|, remove unnecessary #include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -18 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/ValidityState-patternMismatch.html View 2 chunks +19 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/ValidityState-patternMismatch-expected.txt View 2 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/BaseTextInputType.h View 1 2 chunks +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/BaseTextInputType.cpp View 1 2 chunks +28 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
tkent
yukishiino@, would you review bindings/ please? keishi@, would you review core/ and LayoutTests/ please?
4 years, 6 months ago (2016-06-02 06:17:56 UTC) #2
Yuki
LGTM.
4 years, 6 months ago (2016-06-02 07:17:34 UTC) #4
keishi
LGTM
4 years, 6 months ago (2016-06-02 07:33:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2037553002/20001
4 years, 6 months ago (2016-06-02 07:40:53 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-02 09:42:03 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 09:43:31 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf29fb367d40c5b6fc9f41a1c268daa78e4aa031
Cr-Commit-Position: refs/heads/master@{#397352}

Powered by Google App Engine
This is Rietveld 408576698