third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp - Issue 2037553002: INPUT pattern attribute: Enable "unicode" flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

Issue 2037553002: INPUT pattern attribute: Enable "unicode" flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a comment about |mutable|, remove unnecessary #include Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

index 8fc90321d7ff4680422a97f63e808abbb618f94f..c4d1b4e402a5d38cd17731da4bdea6bc06dacfaf 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

@@ -54,6 +54,8 @@ ScriptRegexp::ScriptRegexp(const String& pattern, TextCaseSensitivity caseSensit

v8::Local<v8::RegExp> regex;

if (v8::RegExp::New(context, v8String(isolate, pattern), static_cast<v8::RegExp::Flags>(flags)).ToLocal(&regex))

m_regex.set(isolate, regex);

+ if (tryCatch.HasCaught() && !tryCatch.Message().IsEmpty())

+ m_exceptionMessage = toCoreStringWithUndefinedOrNullCheck(tryCatch.Message()->Get());

}

int ScriptRegexp::match(const String& string, int startFrom, int* matchLength) const