Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2037243003: MD Settings: Set language strings conditionally on OS (Closed)

Created:
4 years, 6 months ago by michaelpg
Modified:
4 years, 6 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Set language strings conditionally on OS On Chrome OS, the language section should be titled "Language and input". Also includes enclosing language strings in <if>s for strings that are only used on certain platforms. BUG=601555 R=stevenjb@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a0633a600bae31ab92c9f6975ce2e8e963a6b190 Cr-Commit-Position: refs/heads/master@{#398450}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -33 lines) Patch
M chrome/app/settings_strings.grdp View 1 3 chunks +41 lines, -30 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/languages_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
michaelpg
4 years, 6 months ago (2016-06-04 00:22:00 UTC) #2
michaelpg
rebase/ping
4 years, 6 months ago (2016-06-07 23:41:47 UTC) #3
stevenjb
lgtm
4 years, 6 months ago (2016-06-08 00:18:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037243003/20001
4 years, 6 months ago (2016-06-08 00:28:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-08 01:30:06 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 01:31:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0633a600bae31ab92c9f6975ce2e8e963a6b190
Cr-Commit-Position: refs/heads/master@{#398450}

Powered by Google App Engine
This is Rietveld 408576698