Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2037233002: Revert of Enable per thread heap for database thread (Closed)

Created:
4 years, 6 months ago by haraken
Modified:
4 years, 6 months ago
Reviewers:
oilpan-reviews, keishi
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable per thread heap for database thread (patchset #12 id:220001 of https://codereview.chromium.org/1909813002/ ) Reason for revert: This CL is causing a top #1 crasher. https://bugs.chromium.org/p/chromium/issues/detail?id=617141 Original issue's description: > Enable per thread heap for database thread > > BUG=591606 > > Committed: https://crrev.com/993e3a74102e0843bebb2f52de1a904f151843d4 > Cr-Commit-Position: refs/heads/master@{#397383} TBR=oilpan-reviews@chromium.org,keishi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=591606 Committed: https://crrev.com/9f495748a0415dfc1ce1899dbcb207fa9982f327 Cr-Commit-Position: refs/heads/master@{#397884}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -33 lines) Patch
M third_party/WebKit/Source/modules/webdatabase/Database.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseAuthorizer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseContext.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseThread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp View 5 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLResultSet.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLStatement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.h View 2 chunks +12 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
haraken
Created Revert of Enable per thread heap for database thread
4 years, 6 months ago (2016-06-03 23:43:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037233002/1
4 years, 6 months ago (2016-06-03 23:44:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-04 01:38:05 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 01:39:11 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9f495748a0415dfc1ce1899dbcb207fa9982f327
Cr-Commit-Position: refs/heads/master@{#397884}

Powered by Google App Engine
This is Rietveld 408576698