Store marker identifiers as AtomicString

Store marker identifiers as AtomicString

Marker identifiers can be better stored as AtomicString (like for instance clip-path identifiers) since
they wil llikely share the same value as an id attribute.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169556

[pdr., 2014-03-19 03:07:35]

On 2014/03/19 02:42:33, rwlbuis wrote:

I think this is reasonable and verified that it works. LGTM

If you plan on doing the rest, could we do them in one followup instead of
several small patches?

[pdr., 2014-03-19 03:07:39]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-03-19 03:07:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/203723007/1

[commit-bot: I haz the power, 2014-03-19 04:14:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 04:14:44]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[pdr., 2014-03-19 04:55:01]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-03-19 04:55:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/203723007/1

[commit-bot: I haz the power, 2014-03-19 06:04:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 06:04:40]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[rwlbuis, 2014-03-19 10:18:32]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2014-03-19 10:18:33]

The CQ bit was unchecked by rob.buis@samsung.com

[rwlbuis, 2014-03-19 11:44:52]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-03-19 11:44:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/203723007/1

[commit-bot: I haz the power, 2014-03-19 12:54:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 12:54:25]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[rwlbuis, 2014-03-19 12:56:59]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-03-19 12:57:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/203723007/1

[commit-bot: I haz the power, 2014-03-19 15:40:29]

Change committed as 169556

[rwlbuis, 2014-03-20 01:50:34]

On 2014/03/19 03:07:35, pdr wrote:
> On 2014/03/19 02:42:33, rwlbuis wrote:
> 
> I think this is reasonable and verified that it works. LGTM
> 
> If you plan on doing the rest, could we do them in one followup instead of
> several small patches?

Which one are you referring to? All I can think of atm are clipper, mask and
filter which are already using AtomicString. But if you know more to convert let
me know!

[pdr., 2014-03-20 18:32:30]

On 2014/03/20 01:50:34, rwlbuis wrote:
> On 2014/03/19 03:07:35, pdr wrote:
> > On 2014/03/19 02:42:33, rwlbuis wrote:
> > 
> > I think this is reasonable and verified that it works. LGTM
> > 
> > If you plan on doing the rest, could we do them in one followup instead of
> > several small patches?
> 
> Which one are you referring to? All I can think of atm are clipper, mask and
> filter which are already using AtomicString. But if you know more to convert
let
> me know!

What about visitedLinkFillPaintUri, visitedLinkStrokePaintUri, strokePaintUri,
and friends?

[rwlbuis, 2014-03-21 16:10:43]

On 2014/03/20 18:32:30, pdr wrote:
> On 2014/03/20 01:50:34, rwlbuis wrote:
> > On 2014/03/19 03:07:35, pdr wrote:
> > > On 2014/03/19 02:42:33, rwlbuis wrote:
> > > 
> > > I think this is reasonable and verified that it works. LGTM
> > > 
> > > If you plan on doing the rest, could we do them in one followup instead of
> > > several small patches?
> > 
> > Which one are you referring to? All I can think of atm are clipper, mask and
> > filter which are already using AtomicString. But if you know more to convert
> let
> > me know!
> 
> What about visitedLinkFillPaintUri, visitedLinkStrokePaintUri, strokePaintUri,
> and friends?

Unfortunately that kind of Uri (IIRC) can be either #foo or
http://www.foo.com/#foo.
Either way chances of a shared string are low with that :(