Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: Source/core/rendering/style/SVGRenderStyle.h

Issue 203723007: Store marker identifiers as AtomicString (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/rendering/style/SVGRenderStyleDefs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/style/SVGRenderStyle.h
diff --git a/Source/core/rendering/style/SVGRenderStyle.h b/Source/core/rendering/style/SVGRenderStyle.h
index 2f94d945f45457953f005ca05bb52f44fa8a1b94..5d0c96981bde17bbee580ce883e308dbfbcfda09 100644
--- a/Source/core/rendering/style/SVGRenderStyle.h
+++ b/Source/core/rendering/style/SVGRenderStyle.h
@@ -89,9 +89,9 @@ public:
static const AtomicString& initialClipperResource() { return nullAtom; }
static const AtomicString& initialFilterResource() { return nullAtom; }
static const AtomicString& initialMaskerResource() { return nullAtom; }
- static String initialMarkerStartResource() { return String(); }
- static String initialMarkerMidResource() { return String(); }
- static String initialMarkerEndResource() { return String(); }
+ static const AtomicString& initialMarkerStartResource() { return nullAtom; }
+ static const AtomicString& initialMarkerMidResource() { return nullAtom; }
+ static const AtomicString& initialMarkerEndResource() { return nullAtom; }
static EMaskType initialMaskType() { return MT_LUMINANCE; }
static EPaintOrder initialPaintOrder() { return PO_NORMAL; }
@@ -282,19 +282,19 @@ public:
}
// Setters for inherited resources
- void setMarkerStartResource(const String& obj)
+ void setMarkerStartResource(const AtomicString& obj)
{
if (!(inheritedResources->markerStart == obj))
inheritedResources.access()->markerStart = obj;
}
- void setMarkerMidResource(const String& obj)
+ void setMarkerMidResource(const AtomicString& obj)
{
if (!(inheritedResources->markerMid == obj))
inheritedResources.access()->markerMid = obj;
}
- void setMarkerEndResource(const String& obj)
+ void setMarkerEndResource(const AtomicString& obj)
{
if (!(inheritedResources->markerEnd == obj))
inheritedResources.access()->markerEnd = obj;
@@ -340,9 +340,9 @@ public:
const AtomicString& clipperResource() const { return resources->clipper; }
const AtomicString& filterResource() const { return resources->filter; }
const AtomicString& maskerResource() const { return resources->masker; }
- String markerStartResource() const { return inheritedResources->markerStart; }
- String markerMidResource() const { return inheritedResources->markerMid; }
- String markerEndResource() const { return inheritedResources->markerEnd; }
+ const AtomicString& markerStartResource() const { return inheritedResources->markerStart; }
+ const AtomicString& markerMidResource() const { return inheritedResources->markerMid; }
+ const AtomicString& markerEndResource() const { return inheritedResources->markerEnd; }
EMaskType maskType() const { return (EMaskType) svg_noninherited_flags.f.maskType; }
EPaintOrder paintOrder() const { return (EPaintOrder) svg_inherited_flags._paintOrder; }
EPaintOrderType paintOrderType(unsigned index) const;
« no previous file with comments | « no previous file | Source/core/rendering/style/SVGRenderStyleDefs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698