Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 203723006: Fixes how to lookup sdk dir to support tests deeper inside test/ folders. (Closed)

Created:
6 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 9 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixes how to lookup sdk dir to support tests deeper inside test/ folders. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=34091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M pkg/code_transformers/lib/src/dart_sdk.dart View 2 chunks +1 line, -14 lines 0 comments Download
M pkg/code_transformers/lib/tests.dart View 2 chunks +19 lines, -0 lines 0 comments Download
M pkg/smoke/test/codegen/testing_resolver_utils.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
this should fix the failing smoke tests in vm bots
6 years, 9 months ago (2014-03-19 01:11:50 UTC) #1
blois
lgtm
6 years, 9 months ago (2014-03-19 01:13:12 UTC) #2
Siggi Cherem (dart-lang)
6 years, 9 months ago (2014-03-19 01:13:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34091 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698