Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2037223002: Add slide in/slide out transition for Herb CCTs (Closed)

Created:
4 years, 6 months ago by Ted C
Modified:
4 years, 6 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add slide in/slide out transition for Herb CCTs BUG=613685 Committed: https://crrev.com/11476a3a92225f19419012e88bb2f7ae02b93e7c Cr-Commit-Position: refs/heads/master@{#397870}

Patch Set 1 #

Patch Set 2 : Add missing xmly bits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -15 lines) Patch
A + chrome/android/java/res/anim/no_anim.xml View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + chrome/android/java/res/anim/slide_in_up.xml View 1 chunk +5 lines, -5 lines 0 comments Download
A + chrome/android/java/res/anim/slide_out_down.xml View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/SeparateTaskCustomTabActivity.java View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Ted C
PTAL
4 years, 6 months ago (2016-06-03 22:42:22 UTC) #2
Yusuf
lgtm
4 years, 6 months ago (2016-06-03 22:45:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037223002/1
4 years, 6 months ago (2016-06-03 22:48:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/76753)
4 years, 6 months ago (2016-06-03 23:15:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037223002/20001
4 years, 6 months ago (2016-06-03 23:34:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-04 00:53:49 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 00:56:25 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/11476a3a92225f19419012e88bb2f7ae02b93e7c
Cr-Commit-Position: refs/heads/master@{#397870}

Powered by Google App Engine
This is Rietveld 408576698