chrome/android/java/src/org/chromium/chrome/browser/customtabs/SeparateTaskCustomTabActivity.java - Issue 2037223002: Add slide in/slide out transition for Herb CCTs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/SeparateTaskCustomTabActivity.java

Issue 2037223002: Add slide in/slide out transition for Herb CCTs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing xmly bits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/SeparateTaskCustomTabActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/SeparateTaskCustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/SeparateTaskCustomTabActivity.java

index f51b1864689b078067bb34744af26d8ba152795e..a52a2a1092ca99ce221f3c24797740181303e7c8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/SeparateTaskCustomTabActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/SeparateTaskCustomTabActivity.java

@@ -68,6 +68,10 @@ public class SeparateTaskCustomTabActivity extends CustomTabActivity {

finish();

} else if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {

ApiCompatibilityUtils.finishAndRemoveTask(this);

+ if (getIntentDataProvider() != null && getIntentDataProvider().isOpenedByChrome()) {

+ overridePendingTransition(R.anim.no_anim, R.anim.slide_out_down);

+ }

} else {

// TODO(tedchoc): This does not work reliably :-/. Need to find a solution for the X

// button and the Android back. Seems to only somewhat work for the