Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2036953002: Abandon offset support with texel buffers (Closed)

Created:
4 years, 6 months ago by csmartdalton
Modified:
4 years, 6 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Abandon offset support with texel buffers We don't seem to require nonzero offsets for texel buffers at this point in time, and requiring this feature greatly reduces the number of desktop clients that can use texel buffers. If we find a use for offsets later we can always add it back as a separate feature. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2036953002 Committed: https://skia.googlesource.com/skia/+/1897cfd7a6e193b42ca95e830e9485f5201a995c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -26 lines) Patch
M include/gpu/GrBufferAccess.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 2 chunks +5 lines, -15 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
csmartdalton
4 years, 6 months ago (2016-06-03 06:02:38 UTC) #4
bsalomon
lgtm
4 years, 6 months ago (2016-06-03 14:36:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036953002/1
4 years, 6 months ago (2016-06-03 15:32:40 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 15:50:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1897cfd7a6e193b42ca95e830e9485f5201a995c

Powered by Google App Engine
This is Rietveld 408576698