Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Issue 2036933002: Do not use a non-standard label attribute in shadow-dom.js (Closed)

Created:
4 years, 6 months ago by hayato
Modified:
4 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not use a non-standard label attribute in shadow-dom.js See https://codereview.chromium.org/2030513002#msg22 for the context. Use id, instead of label. BUG=531990 Committed: https://crrev.com/8258ecdafbf39b5adf9d1c86a859db31ba5cd92b Cr-Commit-Position: refs/heads/master@{#397620}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M third_party/WebKit/LayoutTests/shadow-dom/event-composed.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/event-path-related-target-scoped.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/resources/shadow-dom.js View 3 chunks +13 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036933002/1
4 years, 6 months ago (2016-06-03 02:44:08 UTC) #2
hayato
PTAL
4 years, 6 months ago (2016-06-03 02:45:20 UTC) #6
tkent
lgtm
4 years, 6 months ago (2016-06-03 02:47:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036933002/1
4 years, 6 months ago (2016-06-03 02:54:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 03:49:03 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 03:50:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8258ecdafbf39b5adf9d1c86a859db31ba5cd92b
Cr-Commit-Position: refs/heads/master@{#397620}

Powered by Google App Engine
This is Rietveld 408576698