Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2030513002: Remove Event.relatedTargetScoped and update event path calculation for relatedTarget (Closed)

Created:
4 years, 6 months ago by hayato
Modified:
4 years, 6 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Event.relatedTargetScoped and update event path calculation for relatedTarget See the context: https://github.com/w3c/webcomponents/issues/486 The spec change: - https://github.com/w3c/webcomponents/commit/f113e26bfa999bac730c65ea7418fe787500313c - https://github.com/w3c/webcomponents/commit/b1433e5f3a013ca825f02fb8f7b0e9d6217c0125 BUG=531990 Committed: https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557 Cr-Commit-Position: refs/heads/master@{#397329}

Patch Set 1 #

Patch Set 2 : wip #

Patch Set 3 : wip #

Total comments: 8

Patch Set 4 : lint #

Patch Set 5 : addressed #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -274 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-with-same-related-target-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-dir-expected.txt View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/event-composed.html View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/event-path-related-target-scoped.html View 1 chunk +14 lines, -49 lines 1 comment Download
D third_party/WebKit/LayoutTests/shadow-dom/events-related-target-scoped.html View 1 chunk +0 lines, -114 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/resources/shadow-dom.js View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/DragEvent.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.h View 1 2 4 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.cpp View 1 2 3 chunks +5 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/EventInit.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/EventPath.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/EventPath.cpp View 1 2 3 1 chunk +10 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/events/FocusEvent.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/GestureEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/MouseEvent.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/MouseRelatedEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/MouseRelatedEvent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/PointerEvent.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/RelatedEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/UIEvent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/UIEvent.cpp View 2 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/events/UIEventWithKeyState.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/UIEventWithKeyState.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 38 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030513002/1
4 years, 6 months ago (2016-06-01 06:03:12 UTC) #2
hayato
wip
4 years, 6 months ago (2016-06-01 06:39:33 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030513002/20001
4 years, 6 months ago (2016-06-01 06:39:37 UTC) #7
hayato
PTAL
4 years, 6 months ago (2016-06-01 06:41:03 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/238445)
4 years, 6 months ago (2016-06-01 07:49:40 UTC) #11
hayato
wip
4 years, 6 months ago (2016-06-02 04:06:07 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030513002/40001
4 years, 6 months ago (2016-06-02 04:06:32 UTC) #14
hayato
tkent@, could you take a look? https://codereview.chromium.org/2030513002/diff/40001/third_party/WebKit/LayoutTests/inspector/console/console-dir-expected.txt File third_party/WebKit/LayoutTests/inspector/console/console-dir-expected.txt (right): https://codereview.chromium.org/2030513002/diff/40001/third_party/WebKit/LayoutTests/inspector/console/console-dir-expected.txt#newcode71 third_party/WebKit/LayoutTests/inspector/console/console-dir-expected.txt:71: composed: true This ...
4 years, 6 months ago (2016-06-02 04:13:00 UTC) #16
hayato
lint
4 years, 6 months ago (2016-06-02 04:17:12 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030513002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030513002/60001
4 years, 6 months ago (2016-06-02 04:17:20 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/179587)
4 years, 6 months ago (2016-06-02 04:36:05 UTC) #21
tkent
lgtm https://codereview.chromium.org/2030513002/diff/40001/third_party/WebKit/LayoutTests/shadow-dom/event-path-related-target-scoped.html File third_party/WebKit/LayoutTests/shadow-dom/event-path-related-target-scoped.html (right): https://codereview.chromium.org/2030513002/diff/40001/third_party/WebKit/LayoutTests/shadow-dom/event-path-related-target-scoped.html#newcode5 third_party/WebKit/LayoutTests/shadow-dom/event-path-related-target-scoped.html:5: <div id=host label=host> Please do not use non-standard ...
4 years, 6 months ago (2016-06-02 04:38:00 UTC) #22
hayato
addressed
4 years, 6 months ago (2016-06-02 04:47:14 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030513002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030513002/80001
4 years, 6 months ago (2016-06-02 04:47:32 UTC) #25
hayato
Thank you for the review. https://codereview.chromium.org/2030513002/diff/40001/third_party/WebKit/LayoutTests/shadow-dom/event-path-related-target-scoped.html File third_party/WebKit/LayoutTests/shadow-dom/event-path-related-target-scoped.html (right): https://codereview.chromium.org/2030513002/diff/40001/third_party/WebKit/LayoutTests/shadow-dom/event-path-related-target-scoped.html#newcode5 third_party/WebKit/LayoutTests/shadow-dom/event-path-related-target-scoped.html:5: <div id=host label=host> On ...
4 years, 6 months ago (2016-06-02 04:47:44 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030513002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030513002/80001
4 years, 6 months ago (2016-06-02 04:48:28 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/179610)
4 years, 6 months ago (2016-06-02 05:08:55 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030513002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030513002/80001
4 years, 6 months ago (2016-06-02 06:11:31 UTC) #34
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-02 07:32:57 UTC) #35
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/a4b8210a70c2b5315fbff25cadde8b756137d557 Cr-Commit-Position: refs/heads/master@{#397329}
4 years, 6 months ago (2016-06-02 07:33:58 UTC) #37
kochi
4 years, 6 months ago (2016-06-03 02:31:48 UTC) #38
Message was sent while issue was closed.
lgtm, sorry for the delay.

https://codereview.chromium.org/2030513002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/shadow-dom/event-path-related-target-scoped.html
(right):

https://codereview.chromium.org/2030513002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/shadow-dom/event-path-related-target-scoped.html:7:
<input label="input1"></input>
nit: <input> doesn't need closing tag.

Powered by Google App Engine
This is Rietveld 408576698