Chromium Code Reviews Chromium Code Reviews
Issue
2036913002:
Revert of H264POC: Allow gaps in frame_num. (Closed)
DescriptionRevert of H264POC: Allow gaps in frame_num. (patchset #5 id:80001 of https://codereview.chromium.org/1967893002/ )
Reason for revert:
Still causing stuttering on Mac
Original issue's description:
> H264POC: Allow gaps in frame_num.
>
> This change only removes the restriction, it does not try to detect
> all the cases where doing so is likely to result in problems. In most
> cases (specifically, those where the number of missing frames is much
> less than max_frame_num), the result will be correct.
>
> In incorrect cases the reorder queue could get confused and result in
> strange playback. The existing TODOs for the reorder queue explain how
> to reduce that, but also inserting dummy frames for gaps would help as
> well.
>
> BUG=550854
>
> Committed: https://crrev.com/b6f4380493084007dc4237d28153c0dd3e5d520b
> Cr-Commit-Position: refs/heads/master@{#395164}
>
> Committed: https://crrev.com/7b9ef9cd272c2e245424028df652291a4db283f8
> Cr-Commit-Position: refs/heads/master@{#395661}
TBR=posciak@chromium.org,sandersd@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=550854
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
