components/test_runner/web_view_test_client.cc - Issue 2036873002: Making EventSender talk to the right WebWidget (for OOPIF support).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/web_view_test_client.cc

Issue 2036873002: Making EventSender talk to the right WebWidget (for OOPIF support). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/test_runner/event_sender.cc ('K') | « components/test_runner/web_test_proxy.cc ('k') | content/shell/renderer/layout_test/layout_test_content_renderer_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/web_view_test_client.cc

diff --git a/components/test_runner/web_view_test_client.cc b/components/test_runner/web_view_test_client.cc

index b52af0b09ed4d30ab051b729a1e244d87d196cd3..1c6e9600d7ae0cc75a6f8ca46106de97b095c8b0 100644

--- a/components/test_runner/web_view_test_client.cc

+++ b/components/test_runner/web_view_test_client.cc

@@ -47,7 +47,10 @@ void WebViewTestClient::startDragging(blink::WebLocalFrame* frame,

// When running a test, we need to fake a drag drop operation otherwise

// Windows waits for real mouse events to know when the drag is over.

- web_test_proxy_base_->event_sender()->DoDragDrop(data, mask);

+ // TODO(lukasza): Use |frame|-specific widget, rather than main frame.

+ // DO NOT SUBMIT: This is slightly problematic / prevents ripping out

+ // EventSender from WebTestProxyBase.

+ //web_test_proxy_base_->event_sender()->DoDragDrop(data, mask);

Łukasz Anforowicz 2016/06/02 21:05:19 I am sure we can solve this somehow, but currently

}

// The output from these methods in layout test mode should match that