Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: components/test_runner/web_view_test_client.cc

Issue 2036873002: Making EventSender talk to the right WebWidget (for OOPIF support). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/test_runner/web_view_test_client.h" 5 #include "components/test_runner/web_view_test_client.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/i18n/rtl.h" 9 #include "base/i18n/rtl.h"
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
(...skipping 29 matching lines...) Expand all
40 40
41 void WebViewTestClient::startDragging(blink::WebLocalFrame* frame, 41 void WebViewTestClient::startDragging(blink::WebLocalFrame* frame,
42 const blink::WebDragData& data, 42 const blink::WebDragData& data,
43 blink::WebDragOperationsMask mask, 43 blink::WebDragOperationsMask mask,
44 const blink::WebImage& image, 44 const blink::WebImage& image,
45 const blink::WebPoint& point) { 45 const blink::WebPoint& point) {
46 test_runner_->setDragImage(image); 46 test_runner_->setDragImage(image);
47 47
48 // When running a test, we need to fake a drag drop operation otherwise 48 // When running a test, we need to fake a drag drop operation otherwise
49 // Windows waits for real mouse events to know when the drag is over. 49 // Windows waits for real mouse events to know when the drag is over.
50 web_test_proxy_base_->event_sender()->DoDragDrop(data, mask); 50 // TODO(lukasza): Use |frame|-specific widget, rather than main frame.
51 // DO NOT SUBMIT: This is slightly problematic / prevents ripping out
52 // EventSender from WebTestProxyBase.
53 //web_test_proxy_base_->event_sender()->DoDragDrop(data, mask);
Łukasz Anforowicz 2016/06/02 21:05:19 I am sure we can solve this somehow, but currently
51 } 54 }
52 55
53 // The output from these methods in layout test mode should match that 56 // The output from these methods in layout test mode should match that
54 // expected by the layout tests. See EditingDelegate.m in DumpRenderTree. 57 // expected by the layout tests. See EditingDelegate.m in DumpRenderTree.
55 58
56 void WebViewTestClient::didChangeContents() { 59 void WebViewTestClient::didChangeContents() {
57 if (test_runner_->shouldDumpEditingCallbacks()) 60 if (test_runner_->shouldDumpEditingCallbacks())
58 delegate()->PrintMessage( 61 delegate()->PrintMessage(
59 "EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification\n"); 62 "EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification\n");
60 } 63 }
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 151
149 blink::WebString WebViewTestClient::acceptLanguages() { 152 blink::WebString WebViewTestClient::acceptLanguages() {
150 return blink::WebString::fromUTF8(test_runner_->GetAcceptLanguages()); 153 return blink::WebString::fromUTF8(test_runner_->GetAcceptLanguages());
151 } 154 }
152 155
153 WebTestDelegate* WebViewTestClient::delegate() { 156 WebTestDelegate* WebViewTestClient::delegate() {
154 return web_test_proxy_base_->delegate(); 157 return web_test_proxy_base_->delegate();
155 } 158 }
156 159
157 } // namespace test_runner 160 } // namespace test_runner
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698