Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 2036863002: Remove use of deprecated MessageLoop methods in extensions. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove use of deprecated MessageLoop methods in extensions. MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon are deprecated. This CL makes the following replacements to remove some uses of these methods: "MessageLoop(ForUI|ForIO)::current()->PostTask" -> "ThreadTaskRunnerHandle::Get()->PostTask" "MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" -> "ThreadTaskRunnerHandle::Get()->PostDelayedTask" "MessageLoop(ForUI|ForIO)::current()->DeleteSoon" -> "ThreadTaskRunnerHandle::Get()->DeleteSoon" "MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" -> "ThreadTaskRunnerHandle::Get()->ReleaseSoon" In files where these replacements are made, it adds these includes: #include "base/location.h" #include "base/single_thread_task_runner.h" #include "base/threading/thread_task_runner_handle.h" And removes this include if it is no longer required: #include "base/message_loop/message_loop.h" Why ThreadTaskRunnerHandle::Get() instead of MessageLoop::current()->task_runner()? - The two are equivalent on threads that run a MessageLoop. - MessageLoop::current() doesn't work in base/task_scheduler because the scheduler's thread don't run MessageLoops. This CL will therefore facilitate the migration of browser threads to base/task_scheduler. Steps to generate this patch: 1. Run message_loop_cleanup.py (see code on the bug). 2. Run tools/sort-headers.py on modified files. 3. Run git cl format. BUG=616447 R=reillyg@chromium.org Committed: https://crrev.com/e6609ac829c5562996eb4ad31f8e743eff2f5498 Cr-Commit-Position: refs/heads/master@{#398088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -71 lines) Patch
M extensions/browser/api/cast_channel/cast_socket.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_socket_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_transport.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M extensions/browser/api/hid/hid_device_manager.cc View 2 chunks +4 lines, -1 line 0 comments Download
M extensions/browser/api/management/management_api.cc View 2 chunks +4 lines, -1 line 0 comments Download
M extensions/browser/api/runtime/runtime_api.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/api/serial/serial_connection.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M extensions/browser/api/vpn_provider/vpn_service.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/api/webcam_private/visca_webcam.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_permission_helper.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M extensions/browser/load_monitoring_extension_host_queue.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M extensions/browser/process_manager.cc View 4 chunks +12 lines, -14 lines 0 comments Download
M extensions/browser/serial_extension_host_queue.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M extensions/browser/state_store.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M extensions/renderer/api_test_base.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M extensions/renderer/gc_callback.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M extensions/renderer/guest_view/extensions_guest_view_container.cc View 2 chunks +4 lines, -1 line 0 comments Download
M extensions/renderer/render_frame_observer_natives.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M extensions/renderer/script_context_set.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_aura.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-06 16:40:02 UTC) #2
Reilly Grant (use Gerrit)
lgtm
4 years, 6 months ago (2016-06-06 17:53:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036863002/1
4 years, 6 months ago (2016-06-06 18:00:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 19:21:52 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 19:23:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6609ac829c5562996eb4ad31f8e743eff2f5498
Cr-Commit-Position: refs/heads/master@{#398088}

Powered by Google App Engine
This is Rietveld 408576698