Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: extensions/browser/api/management/management_api.cc

Issue 2036863002: Remove use of deprecated MessageLoop methods in extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/management/management_api.h" 5 #include "extensions/browser/api/management/management_api.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/bind.h" 12 #include "base/bind.h"
13 #include "base/json/json_writer.h" 13 #include "base/json/json_writer.h"
14 #include "base/lazy_instance.h" 14 #include "base/lazy_instance.h"
15 #include "base/location.h"
15 #include "base/logging.h" 16 #include "base/logging.h"
16 #include "base/memory/linked_ptr.h" 17 #include "base/memory/linked_ptr.h"
17 #include "base/memory/ptr_util.h" 18 #include "base/memory/ptr_util.h"
18 #include "base/metrics/histogram.h" 19 #include "base/metrics/histogram.h"
20 #include "base/single_thread_task_runner.h"
19 #include "base/strings/string_number_conversions.h" 21 #include "base/strings/string_number_conversions.h"
20 #include "base/strings/string_util.h" 22 #include "base/strings/string_util.h"
21 #include "base/strings/utf_string_conversions.h" 23 #include "base/strings/utf_string_conversions.h"
24 #include "base/threading/thread_task_runner_handle.h"
22 #include "build/build_config.h" 25 #include "build/build_config.h"
23 #include "content/public/browser/browser_context.h" 26 #include "content/public/browser/browser_context.h"
24 #include "extensions/browser/api/extensions_api_client.h" 27 #include "extensions/browser/api/extensions_api_client.h"
25 #include "extensions/browser/api/management/management_api_constants.h" 28 #include "extensions/browser/api/management/management_api_constants.h"
26 #include "extensions/browser/event_router.h" 29 #include "extensions/browser/event_router.h"
27 #include "extensions/browser/extension_prefs.h" 30 #include "extensions/browser/extension_prefs.h"
28 #include "extensions/browser/extension_registry.h" 31 #include "extensions/browser/extension_registry.h"
29 #include "extensions/browser/extension_system.h" 32 #include "extensions/browser/extension_system.h"
30 #include "extensions/browser/management_policy.h" 33 #include "extensions/browser/management_policy.h"
31 #include "extensions/browser/requirements_checker.h" 34 #include "extensions/browser/requirements_checker.h"
(...skipping 509 matching lines...) Expand 10 before | Expand all | Expand 10 after
541 if (show_confirm_dialog) { 544 if (show_confirm_dialog) {
542 // We show the programmatic uninstall ui for extensions uninstalling 545 // We show the programmatic uninstall ui for extensions uninstalling
543 // other extensions. 546 // other extensions.
544 bool show_programmatic_uninstall_ui = !self_uninstall && extension(); 547 bool show_programmatic_uninstall_ui = !self_uninstall && extension();
545 AddRef(); // Balanced in OnExtensionUninstallDialogClosed. 548 AddRef(); // Balanced in OnExtensionUninstallDialogClosed.
546 // TODO(devlin): A method called "UninstallFunctionDelegate" does not in 549 // TODO(devlin): A method called "UninstallFunctionDelegate" does not in
547 // any way imply that this actually creates a dialog and runs it. 550 // any way imply that this actually creates a dialog and runs it.
548 uninstall_dialog_ = delegate->UninstallFunctionDelegate( 551 uninstall_dialog_ = delegate->UninstallFunctionDelegate(
549 this, target_extension, show_programmatic_uninstall_ui); 552 this, target_extension, show_programmatic_uninstall_ui);
550 } else { // No confirm dialog. 553 } else { // No confirm dialog.
551 base::MessageLoop::current()->PostTask( 554 base::ThreadTaskRunnerHandle::Get()->PostTask(
552 FROM_HERE, 555 FROM_HERE,
553 base::Bind(&ManagementUninstallFunctionBase::UninstallExtension, this)); 556 base::Bind(&ManagementUninstallFunctionBase::UninstallExtension, this));
554 } 557 }
555 558
556 return RespondLater(); 559 return RespondLater();
557 } 560 }
558 561
559 void ManagementUninstallFunctionBase::Finish(bool did_start_uninstall, 562 void ManagementUninstallFunctionBase::Finish(bool did_start_uninstall,
560 const std::string& error) { 563 const std::string& error) {
561 Respond(did_start_uninstall ? NoArguments() : Error(error)); 564 Respond(did_start_uninstall ? NoArguments() : Error(error));
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
900 ManagementAPI::GetFactoryInstance() { 903 ManagementAPI::GetFactoryInstance() {
901 return g_factory.Pointer(); 904 return g_factory.Pointer();
902 } 905 }
903 906
904 void ManagementAPI::OnListenerAdded(const EventListenerInfo& details) { 907 void ManagementAPI::OnListenerAdded(const EventListenerInfo& details) {
905 management_event_router_.reset(new ManagementEventRouter(browser_context_)); 908 management_event_router_.reset(new ManagementEventRouter(browser_context_));
906 EventRouter::Get(browser_context_)->UnregisterObserver(this); 909 EventRouter::Get(browser_context_)->UnregisterObserver(this);
907 } 910 }
908 911
909 } // namespace extensions 912 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/api/hid/hid_device_manager.cc ('k') | extensions/browser/api/runtime/runtime_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698