Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: src/gpu/gl/GrGLCaps.cpp

Issue 2036763002: Exclude Mali devices from manual mip-mapping. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/gl/GrGLCaps.cpp
diff --git a/src/gpu/gl/GrGLCaps.cpp b/src/gpu/gl/GrGLCaps.cpp
index 88ed455bb11cb6c2678af3acdb35751ab9fdefe0..c0fc90189fffc48d883b7e651c3bf51f64b65261 100644
--- a/src/gpu/gl/GrGLCaps.cpp
+++ b/src/gpu/gl/GrGLCaps.cpp
@@ -547,8 +547,10 @@ void GrGLCaps::init(const GrContextOptions& contextOptions,
// Manual mip-mapping requires mip-level sampling control.
// Additionally, Adreno330 will produce empty mip-maps for the very smallest mips with
// our manual (draw-call) implementation.
+ // At least some Mali chips (T604 in Nexus10) produces incorrect (wrt sRGB) mips using draws
if (fMipMapLevelAndLodControlSupport &&
- kAdreno3xx_GrGLRenderer != ctxInfo.renderer()) {
+ kAdreno3xx_GrGLRenderer != ctxInfo.renderer() &&
+ kARM_GrGLVendor != ctxInfo.vendor()) {
fDoManualMipmapping = true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698