Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: src/gpu/gl/GrGLCaps.cpp

Issue 2036763002: Exclude Mali devices from manual mip-mapping. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 8
9 #include "GrGLCaps.h" 9 #include "GrGLCaps.h"
10 10
(...skipping 529 matching lines...) Expand 10 before | Expand all | Expand 10 after
540 ctxInfo.vendor() != kIntel_GrGLVendor) { 540 ctxInfo.vendor() != kIntel_GrGLVendor) {
541 fSampleShadingSupport = true; 541 fSampleShadingSupport = true;
542 } 542 }
543 } else if (ctxInfo.hasExtension("GL_OES_sample_shading")) { 543 } else if (ctxInfo.hasExtension("GL_OES_sample_shading")) {
544 fSampleShadingSupport = true; 544 fSampleShadingSupport = true;
545 } 545 }
546 546
547 // Manual mip-mapping requires mip-level sampling control. 547 // Manual mip-mapping requires mip-level sampling control.
548 // Additionally, Adreno330 will produce empty mip-maps for the very smallest mips with 548 // Additionally, Adreno330 will produce empty mip-maps for the very smallest mips with
549 // our manual (draw-call) implementation. 549 // our manual (draw-call) implementation.
550 // At least some Mali chips (T604 in Nexus10) produces incorrect (wrt sRGB) mips using draws
550 if (fMipMapLevelAndLodControlSupport && 551 if (fMipMapLevelAndLodControlSupport &&
551 kAdreno3xx_GrGLRenderer != ctxInfo.renderer()) { 552 kAdreno3xx_GrGLRenderer != ctxInfo.renderer() &&
553 kARM_GrGLVendor != ctxInfo.vendor()) {
552 fDoManualMipmapping = true; 554 fDoManualMipmapping = true;
553 } 555 }
554 556
555 // Requires fTextureRedSupport, fTextureSwizzleSupport, msaa support, ES com patibility have 557 // Requires fTextureRedSupport, fTextureSwizzleSupport, msaa support, ES com patibility have
556 // already been detected. 558 // already been detected.
557 this->initConfigTable(ctxInfo, gli, glslCaps); 559 this->initConfigTable(ctxInfo, gli, glslCaps);
558 560
559 this->applyOptionsOverrides(contextOptions); 561 this->applyOptionsOverrides(contextOptions);
560 glslCaps->applyOptionsOverrides(contextOptions); 562 glslCaps->applyOptionsOverrides(contextOptions);
561 } 563 }
(...skipping 1357 matching lines...) Expand 10 before | Expand all | Expand 10 after
1919 for (int j = 0; j < kExternalFormatUsageCnt; ++j) { 1921 for (int j = 0; j < kExternalFormatUsageCnt; ++j) {
1920 SkASSERT(defaultEntry.fFormats.fExternalFormat[j] != 1922 SkASSERT(defaultEntry.fFormats.fExternalFormat[j] !=
1921 fConfigTable[i].fFormats.fExternalFormat[j]); 1923 fConfigTable[i].fFormats.fExternalFormat[j]);
1922 } 1924 }
1923 SkASSERT(defaultEntry.fFormats.fExternalType != fConfigTable[i].fFormats .fExternalType); 1925 SkASSERT(defaultEntry.fFormats.fExternalType != fConfigTable[i].fFormats .fExternalType);
1924 } 1926 }
1925 #endif 1927 #endif
1926 } 1928 }
1927 1929
1928 void GrGLCaps::onApplyOptionsOverrides(const GrContextOptions& options) {} 1930 void GrGLCaps::onApplyOptionsOverrides(const GrContextOptions& options) {}
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698