Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2036763002: Exclude Mali devices from manual mip-mapping. (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Exclude Mali devices from manual mip-mapping. With manual mip-mapping, the Nexus 10 is failing the sRGB mip-map test. That suggests a failure in the sRGB implementation (decode after bilerp, possibly?). Using the driver's mip-mapper resolves the unit test issue, at least. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2036763002 Committed: https://skia.googlesource.com/skia/+/21c5ec62aab4be1fa1bfa06167ce8fd4c9decb35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Brian Osman
The Nexus 10 bots were failing my sRGB mipmap test with the new manual mip-mapper. ...
4 years, 6 months ago (2016-06-02 17:04:41 UTC) #2
Brian Osman
4 years, 6 months ago (2016-06-02 17:05:25 UTC) #4
robertphillips
lgtm
4 years, 6 months ago (2016-06-02 17:07:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036763002/1
4 years, 6 months ago (2016-06-02 17:08:15 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 17:19:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/21c5ec62aab4be1fa1bfa06167ce8fd4c9decb35

Powered by Google App Engine
This is Rietveld 408576698