Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2036743002: [Merge M52] Avoid deleting RenderProcessHostImpl for in-process (Closed)

Created:
4 years, 6 months ago by boliu
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Merge M52] Avoid deleting RenderProcessHostImpl for in-process This is suspected to be the cause of null pointer crash in Android WebView when RenderProcessHostImpl::FromID unexpectedly returns null. Issue is RenderProcessHostImpl::DecrementWorkerRefCount does not check for run_renderer_in_process() like RemoveRoute. Move the check to beginning of Cleanup instead. BUG=616476 Review-Url: https://codereview.chromium.org/2029623002 Cr-Commit-Position: refs/heads/master@{#397235} (cherry picked from commit 55cb5a389f401a539225c7e7b59197114db5cd29) Committed: https://chromium.googlesource.com/chromium/src/+/53b10adeda96e325d3c1ebdb81bf5a370400999d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
boliu
4 years, 6 months ago (2016-06-02 15:40:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
53b10adeda96e325d3c1ebdb81bf5a370400999d.

Powered by Google App Engine
This is Rietveld 408576698