Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2029623002: Avoid deleting RenderProcessHostImpl for in-process (Closed)

Created:
4 years, 6 months ago by boliu
Modified:
4 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid deleting RenderProcessHostImpl for in-process This is suspected to be the cause of null pointer crash in Android WebView when RenderProcessHostImpl::FromID unexpectedly returns null. Issue is RenderProcessHostImpl::DecrementWorkerRefCount does not check for run_renderer_in_process() like RemoveRoute. Move the check to beginning of Cleanup instead. BUG=616476 Committed: https://crrev.com/55cb5a389f401a539225c7e7b59197114db5cd29 Cr-Commit-Position: refs/heads/master@{#397235}

Patch Set 1 #

Patch Set 2 : check in clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029623002/1
4 years, 6 months ago (2016-06-01 15:49:30 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-01 17:16:59 UTC) #4
boliu
ptal
4 years, 6 months ago (2016-06-01 17:20:15 UTC) #6
Avi (use Gerrit)
This looks right, but this seems a little subtle. So we never want to call ...
4 years, 6 months ago (2016-06-01 17:38:53 UTC) #7
boliu
On 2016/06/01 17:38:53, Avi wrote: > This looks right, but this seems a little subtle. ...
4 years, 6 months ago (2016-06-01 17:48:03 UTC) #9
Avi (use Gerrit)
lgtm Yep!
4 years, 6 months ago (2016-06-01 18:51:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029623002/20001
4 years, 6 months ago (2016-06-01 19:01:06 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 20:44:50 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 20:46:29 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55cb5a389f401a539225c7e7b59197114db5cd29
Cr-Commit-Position: refs/heads/master@{#397235}

Powered by Google App Engine
This is Rietveld 408576698