sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart - Issue 203673003: Allow [path.fromUri] to take a string as well as a URI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart

Issue 203673003: Allow [path.fromUri] to take a string as well as a URI. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/build_environment.dart ('k') | sdk/lib/_internal/pub/lib/src/command/build.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart

diff --git a/sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart b/sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart

index 7740ba60f450c4c165ecdc4880b04a984a2f27bc..dd90b9f688a947de75b58271af16c86126708d41 100644

--- a/sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart

+++ b/sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart

@@ -24,7 +24,7 @@ class PubPackageProvider implements PackageProvider {

Future<Asset> getAsset(AssetId id) {

if (id.package != r'$pub') {

- var nativePath = path.joinAll(path.url.split(id.path));

+ var nativePath = path.fromUri(id.path);

var file = path.join(_graph.packages[id.package].dir, nativePath);

return new Future.value(new Asset.fromPath(id, file));

}

« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/build_environment.dart ('k') | sdk/lib/_internal/pub/lib/src/command/build.dart » ('j') | no next file with comments »