sdk/lib/_internal/pub/lib/src/barback/build_environment.dart - Issue 203673003: Allow [path.fromUri] to take a string as well as a URI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/build_environment.dart

Issue 203673003: Allow [path.fromUri] to take a string as well as a URI. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/pub/lib/src/barback/build_environment.dart

diff --git a/sdk/lib/_internal/pub/lib/src/barback/build_environment.dart b/sdk/lib/_internal/pub/lib/src/barback/build_environment.dart

index 82fa93418c8f46a3f26d0cc88855d57260fc84e7..546357ac57cd5925bc3d71867c773c89b9aa5c57 100644

--- a/sdk/lib/_internal/pub/lib/src/barback/build_environment.dart

+++ b/sdk/lib/_internal/pub/lib/src/barback/build_environment.dart

@@ -437,7 +437,7 @@ void _log(LogEntry entry) {

messageMentionsAsset(id) =>

messageMentions(id.toString()) ||

- messageMentions(path.joinAll(path.url.split(entry.assetId.path)));

+ messageMentions(path.fromUri(entry.assetId.path));

var prefixParts = [];

« no previous file with comments | « pkg/path/test/windows_test.dart ('k') | sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart » ('j') | no next file with comments »