Issue 2036643004: Create ForTesting method rather than declaring a dozen "friend" classes.

Issue 2036643004: Create ForTesting method rather than declaring a dozen "friend" classes. (Closed)

Created:
4 years, 6 months ago by bcwhite

Modified:
4 years, 6 months ago

Reviewers:
Alexei Svitkine (slow)

CC:
chromium-reviews, asvitkine+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Create ForTesting method rather than declaring a dozen "friend" classes. BUG=546019 Committed: https://crrev.com/9e3835ccbdd5f3065f77c1890b7535a11ded39a2 Cr-Commit-Position: refs/heads/master@{#397749}

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -27 lines)			Patch
M	base/metrics/histogram_base_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/metrics/histogram_delta_serialization_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	base/metrics/histogram_snapshot_manager_unittest.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	base/metrics/histogram_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/metrics/persistent_histogram_allocator_unittest.cc	View	1 2 3	3 chunks	+6 lines, -7 lines	0 comments	Download
M	base/metrics/sparse_histogram_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/metrics/statistics_recorder.h	View	1 2 3	2 chunks	+9 lines, -12 lines	0 comments	Download
M	base/metrics/statistics_recorder.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	base/metrics/statistics_recorder_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/metrics/subprocess_metrics_provider_unittest.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 12 (7 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036643004/100001

4 years, 6 months ago (2016-06-03 17:51:50 UTC) #8

commit-bot: I haz the power

4 years, 6 months ago (2016-06-03 18:00:16 UTC) #12

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/9e3835ccbdd5f3065f77c1890b7535a11ded39a2
Cr-Commit-Position: refs/heads/master@{#397749}