base/metrics/histogram_base_unittest.cc - Issue 2036643004: Create ForTesting method rather than declaring a dozen "friend" classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_base_unittest.cc

Issue 2036643004: Create ForTesting method rather than declaring a dozen "friend" classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/metrics/histogram_base_unittest.cc

diff --git a/base/metrics/histogram_base_unittest.cc b/base/metrics/histogram_base_unittest.cc

index 5ce39cabe1f602fa6f01a2e94ac8493f3b44f138..1eb8fd46084ba2c82d396db9f810042b90376f5d 100644

--- a/base/metrics/histogram_base_unittest.cc

+++ b/base/metrics/histogram_base_unittest.cc

@@ -29,7 +29,7 @@ class HistogramBaseTest : public testing::Test {

// It is necessary to fully destruct any existing StatisticsRecorder

// before creating a new one.

statistics_recorder_.reset();

- statistics_recorder_.reset(new StatisticsRecorder());

+ statistics_recorder_ = StatisticsRecorder::CreateTemporaryForTesting();

}

HistogramBase* GetCreationReportHistogram(const std::string& name) {

« no previous file with comments | « no previous file | base/metrics/histogram_delta_serialization_unittest.cc » ('j') | no next file with comments »