mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd16_uknown_non_extensible_enum_map_value.data - Issue 2036623002: Validate map keys in C++ Mojo bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd16_uknown_non_extensible_enum_map_value.data

Issue 2036623002: Validate map keys in C++ Mojo bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd16_uknown_non_extensible_enum_map_key.expected ('k') | mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd16_uknown_non_extensible_enum_map_value.expected » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd16_uknown_non_extensible_enum_map_value.data

diff --git a/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd10_null_keys.data b/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd16_uknown_non_extensible_enum_map_value.data

similarity index 59%

copy from mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd10_null_keys.data

copy to mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd16_uknown_non_extensible_enum_map_value.data

index 3a99dc2ab87ad1ae29fc12854e0e2d3bece6a963..2c2ea26d93ec24d6f393c269d37ff759d495a7c1 100644

--- a/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd10_null_keys.data

+++ b/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd16_uknown_non_extensible_enum_map_value.data

@@ -1,25 +1,34 @@

[dist4]message_header // num_bytes

[u4]0 // version

[u4]0 // interface ID

-[u4]10 // name

+[u4]16 // name

[u4]0 // flags

[u4]0 // padding

[anchr]message_header

-[dist4]method10_params // num_bytes

+[dist4]method16_params // num_bytes

[u4]0 // version

[dist8]map_data_ptr // param0

-[anchr]method10_params

+[anchr]method16_params

[anchr]map_data_ptr

[dist4]map_data_struct_header // num_bytes

[u4]0 // version

-[u8]0 // null keys array

+[dist8]key_array_ptr

[dist8]value_array_ptr

[anchr]map_data_struct_header

+[anchr]key_array_ptr

+[dist4]key_array_member // num_bytes

+[u4]2 // num_elements

+[u4]1

+[u4]2

+[anchr]key_array_member

[anchr]value_array_ptr

[dist4]value_array_member // num_bytes

[u4]2 // num_elements

-1 2

+[u4]0x5678 // Unknown value is not allowed for non-extensible

+ // enum.

+[u4]1

[anchr]value_array_member