mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd16_uknown_non_extensible_enum_map_value.data - Issue 2036623002: Validate map keys in C++ Mojo bindings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd16_uknown_non_extensible_enum_map_value.data

Issue 2036623002: Validate map keys in C++ Mojo bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 [dist4]message_header // num_bytes	1 [dist4]message_header // num_bytes

2 [u4]0 // version	2 [u4]0 // version

3 [u4]0 // interface ID	3 [u4]0 // interface ID

4 [u4]10 // name	4 [u4]16 // name

5 [u4]0 // flags	5 [u4]0 // flags

6 [u4]0 // padding	6 [u4]0 // padding

7 [anchr]message_header	7 [anchr]message_header

8	8

9 [dist4]method10_params // num_bytes	9 [dist4]method16_params // num_bytes

10 [u4]0 // version	10 [u4]0 // version

11 [dist8]map_data_ptr // param0	11 [dist8]map_data_ptr // param0

12 [anchr]method10_params	12 [anchr]method16_params

13	13

14 [anchr]map_data_ptr	14 [anchr]map_data_ptr

15 [dist4]map_data_struct_header // num_bytes	15 [dist4]map_data_struct_header // num_bytes

16 [u4]0 // version	16 [u4]0 // version

17 [u8]0 // null keys array	17 [dist8]key_array_ptr

18 [dist8]value_array_ptr	18 [dist8]value_array_ptr

19 [anchr]map_data_struct_header	19 [anchr]map_data_struct_header

20	20

	21 [anchr]key_array_ptr

	22 [dist4]key_array_member // num_bytes

	23 [u4]2 // num_elements

	24 [u4]1

	25 [u4]2

	26 [anchr]key_array_member

	27

21 [anchr]value_array_ptr	28 [anchr]value_array_ptr

22 [dist4]value_array_member // num_bytes	29 [dist4]value_array_member // num_bytes

23 [u4]2 // num_elements	30 [u4]2 // num_elements

24 1 2	31 [u4]0x5678 // Unknown value is not allowed for non-extensible

	32 // enum.

	33 [u4]1

25 [anchr]value_array_member	34 [anchr]value_array_member

OLD	NEW